[TRTLLMINF-336][infra] BOLT profile merge: skip runtime tensorrt import gate (libs-only) - #18395
Conversation
Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe setup script now supports libraries-only installation without TensorRT runtime checks. The Slurm merge job enables this mode before backing up libraries and converting profiling data. Normal setup retains its existing TensorRT validation. ChangesLibrary-only environment setup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR adds a libraries-only setup path for BOLT profile merging while preserving library installation and verified merge behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #70094 [ run ] triggered by Bot. Commit: |
|
PR_Github #70094 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #70113 [ run ] triggered by Bot. Commit: |
|
PR_Github #70113 [ run ] completed with state
|
|
/bot skip --comment "Failure unrelated" |
|
PR_Github #70164 [ skip ] triggered by Bot. Commit: |
|
PR_Github #70164 [ skip ] completed with state |
Description
The cross-workload BOLT profile merge (
scripts/bolt/internal/slurm_merge.sh) failed insetup_env.sh's runtimeimport tensorrtgate: the profiling base image (pytorch-…-skip-tritondevel) has no importabletensorrtbefore install. The merge doesn't need one — it only reconstructs the wheel's ELF.sofiles on disk to convert.fdata → .yaml(llvm-bolt <orig.so> -data -w <yaml>) and to re-BOLT viaapply_bolt.py, and library discovery resolves the package by path (importlib.util.find_spec), not by importing it.Changes
BOLT_SETUP_LIBS_ONLY=1mode tosetup_env.shthat skips the runtimeimport tensorrt/import tensorrt_llmchecks while keeping thepip install --no-depsthat lays the.sos on disk.BOLT_SETUP_LIBS_ONLY=1fromslurm_merge.sh.Test Coverage
Re-ran the merge end-to-end against real collected profiles: libs-only
setup_env.sh→backup_libraries→merge-fdata→.fdata → .yaml→ bundle packaging →apply_bolt.pyre-BOLT all completed successfully.Dev Engineer Review
BOLT_SETUP_LIBS_ONLY=1support toscripts/bolt/setup_env.sh.scripts/bolt/internal/slurm_merge.shto enable the mode.QA Engineer Review
No test changes.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.