Skip to content

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Nov 2, 2025

Summary by CodeRabbit

  • Chores
    • Adjusted multi-node SBSA test configurations to narrow the test scope and streamline test execution.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@EmmaQiaoCh EmmaQiaoCh requested a review from a team as a code owner November 2, 2025 03:13
@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 2, 2025

📝 Walkthrough

Walkthrough

A configuration parameter in the Groovy test file is adjusted, reducing the multi-node SBSA configuration range from 1..7 to 1..3 and updating the corresponding split count value from 7 to 3.

Changes

Cohort / File(s) Summary
Test Configuration Adjustment
jenkins/L0_Test.groovy
Narrowed multi-node SBSA configuration range from 1..7 to 1..3; updated split count parameter value from 7 to 3

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is almost entirely empty of substantive content. While the pull request contains the repository's description template with section headers for "Description," "Test Coverage," and "PR Checklist," all three main sections lack actual implementation details, rationale, or concrete information about the changes. The only action taken was checking the final checklist box, but no explanations were provided for what changed, why it changed, or how the changes are tested. The pr_objectives confirm this, stating "No explicit implementation details, code changes, test cases, or concrete description of the change to GB200 multi-node test stages are provided in the PR body."
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[TRTLLM-8813][infra] Reduce GB200 multi-node test stages for release" directly aligns with the primary change in the pull request: reducing the multi-node SBSA configuration range from 1..7 to 1..3 (reducing the split count from 7 to 3) in the jenkins/L0_Test.groovy file. The title follows the required format with a valid JIRA ticket, appropriate type tag, and is specific and concise enough that a teammate scanning history would immediately understand this is about reducing test stages for the GB200 multi-node configuration.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)

2192-2193: LGTM! Reduction from 7 to 3 stages is correct and consistent.

The change correctly reduces the GB200 multi-node test stages from 7 to 3 for the release branch. Both the range (1..3) and the split count parameter (4th element: 3) are now consistent with each other, which matches the configuration format documented in the file.

Consider adding a brief comment explaining the reduction for future maintainability:

     multiNodesSBSAConfigs = [:]
+    // Reduced split count for release branch to optimize resource usage
     multiNodesSBSAConfigs += (1..3).collectEntries { i ->
         ["GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-${i}".toString(), ["gb200-multi-node", "l0_gb200_multi_nodes", i, 3, 8, 2]]
     }
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ff1adb and 3f80335.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23269 [ run ] triggered by Bot. Commit: 3f80335

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23269 [ run ] completed with state SUCCESS. Commit: 3f80335
/LLM/release-1.1/L0_MergeRequest_PR pipeline #361 (Partly Tested) completed with status: 'SUCCESS'

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23353 [ run ] triggered by Bot. Commit: 0a5b251

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23353 [ run ] completed with state SUCCESS. Commit: 0a5b251
/LLM/release-1.1/L0_MergeRequest_PR pipeline #378 (Partly Tested) completed with status: 'SUCCESS'

@EmmaQiaoCh EmmaQiaoCh force-pushed the emma/reduce_gp200_stages_for_release branch from 0a5b251 to 9b110b6 Compare November 3, 2025 12:51
@EmmaQiaoCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23392 [ run ] triggered by Bot. Commit: 9b110b6

@EmmaQiaoCh EmmaQiaoCh force-pushed the emma/reduce_gp200_stages_for_release branch from 9b110b6 to f7d1c8c Compare November 4, 2025 06:10
@EmmaQiaoCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23471 [ run ] triggered by Bot. Commit: f7d1c8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants