refactor: isolate model families end to end - #1093
Open
yifeif-nv wants to merge 3 commits into
Open
Conversation
|
Caution CodeRabbit couldn't post its review summary. Error details |
yifeif-nv
force-pushed
the
agent/ai-native-horizontal-scale
branch
from
August 29, 2026 23:29
5a8e111 to
8c77059
Compare
|
Caution CodeRabbit couldn't post its review summary. Error details |
yifeif-nv
force-pushed
the
agent/ai-native-horizontal-scale
branch
from
August 29, 2026 23:49
8c77059 to
8253660
Compare
|
Caution CodeRabbit couldn't post its review summary. Error details |
yifeif-nv
force-pushed
the
agent/ai-native-horizontal-scale
branch
from
August 30, 2026 00:09
8253660 to
e0be104
Compare
|
Caution CodeRabbit couldn't post its review summary. Error details |
yifeif-nv
force-pushed
the
agent/ai-native-horizontal-scale
branch
from
August 30, 2026 00:36
e0be104 to
3daa7c0
Compare
|
Caution CodeRabbit couldn't post its review summary. Error details |
yifeif-nv
force-pushed
the
agent/ai-native-horizontal-scale
branch
from
August 30, 2026 00:56
3daa7c0 to
3d07318
Compare
|
Caution CodeRabbit couldn't post its review summary. Error details |
yifeif-nv
force-pushed
the
agent/ai-native-horizontal-scale
branch
from
August 30, 2026 01:44
3d07318 to
474cbe1
Compare
|
Caution CodeRabbit couldn't post its review summary. Error details |
Move every model family into a self-owned build, runtime, and test slice. Keep shared Python and native code limited to bundle, loader, task, engine, BYOK, and CI contracts. Preserve BYOK, performance benchmarking, Cosmos dual-Spark, and VoiceChat as one-way applications over the public build, load, and abstract Task APIs. Keep family-specific preprocessing and request validation inside each family. BREAKING CHANGE: remove the legacy builders, runtime registry, bundle format, profiles, validation framework, obsolete tooling, and compatibility paths. Existing bundles and integrations must be rebuilt against the new public contracts. Signed-off-by: yifeif-nv <277870278+yifeif-nv@users.noreply.github.com>
yifeif-nv
force-pushed
the
agent/ai-native-horizontal-scale
branch
from
August 30, 2026 07:04
474cbe1 to
89bf793
Compare
|
Caution CodeRabbit couldn't post its review summary. Error details |
|
This is an automated Internal CI result; no review from an individual maintainer is requested. Open the public Source Actions run from the automated status link above. |
|
Caution CodeRabbit couldn't post its review summary. Error details |
Use the preinstalled build toolchain so wheel and sdist validation can stay offline, and make the development image provide the MPI and NCCL runtime used by tensor-parallel E2E tests. Allocate decoder KV caches with rank-local widths across affected families. Preserve Qwen-MoE replication and DeepSeek-V2 MLA geometry, with family-owned contract tests for GPT-2 and DeepSeek-V2. Signed-off-by: yifeif-nv <277870278+yifeif-nv@users.noreply.github.com>
yifeif-nv
force-pushed
the
agent/ai-native-horizontal-scale
branch
from
August 30, 2026 09:38
10241b6 to
202a7f9
Compare
|
Caution CodeRabbit couldn't post its review summary. Error details |
The protected bridge now consumes only the private workflow conclusion, so it no longer needs to pass a Source revision for the retired public-failure renderer. Keep the exact PR head, base, and dispatch nonce as the complete cross-repository contract. Signed-off-by: yifeif-nv <277870278+yifeif-nv@users.noreply.github.com>
|
Caution CodeRabbit couldn't post its review summary. Error details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The previous repository split each model across central builder, runtime, registration, validation, and documentation systems. Adding a family therefore required shared model changes and increased cross-family coupling. This PR atomically replaces that layout with the architecture documented in
website/docs/architecture/ai-native-horizontal-scaling.md.Exit Criteria
families/<family>/.Implementation
model.py::build(request, writer)structural contract. Builder inheritance is forbidden.libtrtmc_model_<family>.so.trtmc-bench, the performance matrix, the native worker, and dataset benchmark over the public build/load/Task APIs. Output contracts are closed and fail on unknown or mismatched results.Change categories
Validation
Commands and Results
Exact head:
9ba50b00c0d2f8f0aa89c5a4aa14922a7f7b214apython3 -m tools.ci pipeline premerge-unitin a network-disabled, GPU-free, read-only-source container: 203 Python tests passed, 271 explicitly unselected model E2Es skipped, 775 native targets built, and 47/47 CTests passed.python3 -m tools.ci pipeline packagewith no network: built, installed, imported, RTLD-loaded, and validated one wheel containing 85 builders, 85 family DSOs, BYOK, benchmark executables, manifests, and referenced benchmark assets.python3 -m build --no-isolation --sdistfollowed by an offline wheel build from the unpacked sdist: passed; the rebuilt wheel passed the same archive, install, CLI, import, and RTLD validation.192and DeepSeek-V2 MLA TP4 width768.mpirun --tag-output -np 1 trueas the container root and directlibnccl.so.2loading through the configured runtime path: passed.distilgpt2andgpt2-125mcheckpoint-to-bundle-to-native Task API cases passed. The corrected TP4 case built all four rank engines, passed the previous cache-shape failure, and entered NCCL/CUDA execution; rank 3 then hit an uncorrectable NVLink hardware error, so TP4 inference is not claimed as passed locally.TRTMC_ENABLE_BYOK=OFFconfigure/build: passed; ordinary core/runtime/backend/CLI remain buildable without the BYOK DSO.trtmc::trtmc_byok_tvm_ffi: compiled with<trtmc/byok.h>.trtmc-benchmedia dry-run resolved its image from the packaged catalog outside the source checkout.npm run test:model-supportand the production Docusaurus build passed; exact-head Community CPU Docs also passed.No merge has been attempted.
Hardware, Environment, and Revisions
9ba50b00c0d2f8f0aa89c5a4aa14922a7f7b214a10270b7f9e3d0610a9f7f04c59511d190ee83ce0sm_100.Not Run / Remaining Gaps
Notes For Future Readers
Risk level
Risk rationale: this deliberately replaces every family build/runtime/test path, the bundle/API/ABI contract, packaging, documentation, and CI in one incompatible change.