Misc fixes #106
Merged
Misc fixes #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g mode CUDA compilation flags and optix module/pipeline creation flags must match. Forcing O1 debug flag on debug builds was making the debug experience slightly less convenient.
When building in debug mode or forcing no-inline, where parameters are then passed on the stack, the lambda capture ends up referencing values which were popped of the stack by the time the async callback is run, leading to crashes. The issue is less/not reproducible with optimized builds, most likely due to the way parameter passing is changed.
The content expected by ANARI samplers are unsigned, while MDL deals with signed ints. Do the conversion upfront. Note that we cast to unsigned first. Unsigned are having a fully defined wrapping behavior, while wrapping on signed is considered UB and can be optimized in any possible way by the compiler.
Quoting OptiX documentation for optixPipelineSetStackSize: `If this method is not used, an internal default implementation is used. The default implementation is correct (but not necessarily optimal) as long as the maximum depth of call trees of CC programs is at most 2, and no DC programs or motion transforms are used.` Given that we are using direct callables, the default heuristic is not giving the expected result and can result in crashes when run using cuda compute sanitizer. Ensure that we actually push the correct stack sizes for our pipelines.
Collaborator
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims at enabling better CUDA/OptiX debugging and tracing experience.
Also fixes a few issues with pipeline compilation WRT thread safety and device stack size.