Skip to content

Tutorials/Accelerated Python/Kernel Authoring: Fixes and improvements to kernel authoring notebooks#147

Closed
brycelelbach wants to merge 6 commits intomainfrom
fix/python-kernel-authoring-notebooks
Closed

Tutorials/Accelerated Python/Kernel Authoring: Fixes and improvements to kernel authoring notebooks#147
brycelelbach wants to merge 6 commits intomainfrom
fix/python-kernel-authoring-notebooks

Conversation

@brycelelbach
Copy link
Collaborator

Fixes and improvements to the kernel authoring notebooks (40__kernel_authoring_* and 41__kernel_authoring_*).

Changes

  • Book histogram notebooks: Reformatted one-liner plot code into readable multi-line statements, added "Top 20 Bins" title to histogram plots, and added dataset size display.
  • Solution notebook: Cleared hardcoded execution counts.

… plot formatting, add title and dataset size display.
…ctness check to copy kernel launch function.
… dataset size in megabytes instead of bytes.

Made-with: Cursor
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 3, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

❌ Commit Signature Check Failed

Found 1 unsigned commit(s):

🔗 View workflow run logs

  • f4add4b: Tutorials/Accelerated Python/Kernel Authoring: Add configurable correctness check to copy kernel launch function. (unsigned)

All commits must be signed

How to fix:

  1. Configure commit signing (if not already done):

    # For GPG signing
    git config --global commit.gpgsign true
    
    # Or for SSH signing (Git 2.34+)
    git config --global gpg.format ssh
    git config --global user.signingkey ~/.ssh/id_ed25519.pub
  2. Re-sign your commits:

    git rebase -i origin/main --exec "git commit --amend --no-edit -S"
    git push --force-with-lease

📚 GitHub documentation on signing commits

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

❌ Link Check Failed

Broken links were detected in this PR.

Please check the workflow run logs for details on which links are broken.

Common fixes:

  1. Typo in URL - Check for spelling mistakes in the link
  2. Outdated link - The page may have moved or been deleted
  3. Relative path issue - Ensure relative links use the correct path
  4. External site down - If the external site is temporarily down, you can add it to brev/.lycheeignore

To test links locally:

./brev/test-links.bash .

📚 Lychee documentation

…cell before profiling copy_blocked kernel.

Add a verification cell that runs the script immediately after the %%writefile cell, matching the pattern used in the book histogram notebook.

Made-with: Cursor
…ion header, and text updates to solution notebooks.

These changes were made to the exercise notebooks in 2f5c4fc but
were not applied to the corresponding solution notebooks.

Made-with: Cursor
@brycelelbach
Copy link
Collaborator Author

Closing in favor of a new PR with broadened scope (now includes power iteration notebook fixes).

@brycelelbach brycelelbach deleted the fix/python-kernel-authoring-notebooks branch March 3, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant