Skip to content

fix: remove admission.cdi from kai-scheduler values#146

Merged
mchmarny merged 3 commits intoNVIDIA:mainfrom
yuanchen8911:fix/remove-kai-cdi-setting
Feb 19, 2026
Merged

fix: remove admission.cdi from kai-scheduler values#146
mchmarny merged 3 commits intoNVIDIA:mainfrom
yuanchen8911:fix/remove-kai-cdi-setting

Conversation

@yuanchen8911
Copy link
Contributor

@yuanchen8911 yuanchen8911 commented Feb 18, 2026

Summary

Remove unused admission.cdi: true from kai-scheduler component values.

Motivation / Context

CDI admission is only required for GPU sharing (fractional GPU) scenarios not currently
deployed. The reference cluster does not set this flag, and removing it avoids potential
compatibility issues with GPU Operator.

Fixes: N/A
Related: N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Build/CI/tooling

Component(s) Affected

  • CLI (cmd/eidos, pkg/cli)
  • API server (cmd/eidosd, pkg/api, pkg/server)
  • Recipe engine / data (pkg/recipe)
  • Bundlers (pkg/bundler, pkg/component/*)
  • Collectors / snapshotter (pkg/collector, pkg/snapshotter)
  • Validator (pkg/validator)
  • Core libraries (pkg/errors, pkg/k8s)
  • Docs/examples (docs/, examples/)
  • Other: ____________

Implementation Notes

Removed admission.cdi: true from recipes/components/kai-scheduler/values.yaml.

Testing

make lint
make test

Risk Assessment

  • Low — Isolated change, well-tested, easy to revert
  • Medium — Touches multiple components or has broader impact
  • High — Breaking change, affects critical paths, or complex rollout

Rollout notes: N/A

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality
  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S) — GPG signing info

@yuanchen8911 yuanchen8911 requested a review from a team as a code owner February 18, 2026 23:27
@yuanchen8911 yuanchen8911 force-pushed the fix/remove-kai-cdi-setting branch from fa4729d to 31864a4 Compare February 18, 2026 23:47
@yuanchen8911 yuanchen8911 force-pushed the fix/remove-kai-cdi-setting branch from 6dbae83 to 754772c Compare February 19, 2026 00:24
@yuanchen8911 yuanchen8911 changed the title fix: remove admission.cdi from kai-scheduler values fix: remove kai-scheduler CDI setting and fix welcome workflow lint Feb 19, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
@yuanchen8911 yuanchen8911 changed the title fix: remove kai-scheduler CDI setting and fix welcome workflow lint fix: remove admission.cdi from kai-scheduler values Feb 19, 2026
@yuanchen8911 yuanchen8911 force-pushed the fix/remove-kai-cdi-setting branch from 754772c to 49a353d Compare February 19, 2026 02:54
@github-actions github-actions bot added size/XS and removed size/S labels Feb 19, 2026
Copy link
Member

@mchmarny mchmarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mchmarny mchmarny merged commit fa58fba into NVIDIA:main Feb 19, 2026
15 checks passed
@mchmarny mchmarny deleted the fix/remove-kai-cdi-setting branch February 19, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants