feat(validator): self-contained gang scheduling conformance check#184
Merged
dims merged 1 commit intoNVIDIA:mainfrom Feb 23, 2026
Merged
feat(validator): self-contained gang scheduling conformance check#184dims merged 1 commit intoNVIDIA:mainfrom
dims merged 1 commit intoNVIDIA:mainfrom
Conversation
044d0a1 to
d43c901
Compare
ede7e01 to
fffb7ce
Compare
Make the gang-scheduling conformance check fully self-contained by programmatically creating test resources instead of relying on pre-deployed manifests. The check now: 1. Verifies KAI scheduler deployments and CRDs (unchanged) 2. Pre-flight: counts free GPUs via ResourceSlices/ResourceClaims and fails fast if fewer than 2 are available 3. Creates a PodGroup with 2 GPU test pods using DRA ResourceClaims 4. Waits for all pods to reach terminal state 5. Validates gang scheduling patterns (kai-scheduler, PodGroup labels, DRA resource claims, pod success) 6. Cleans up all test resources Adds countAvailableGPUs() helper to conformance/helpers.go for reuse by other GPU-dependent checks. Remove redundant "Deploy gang scheduling test" and cleanup steps from the GPU training CI workflow since the conformance check now handles this end-to-end.
fffb7ce to
23d3fa0
Compare
dims
referenced
this pull request
in dims/aicr
Feb 25, 2026
The GPU Conformance Test (nvkind + H100 x2) workflow was created on
PR #180's branch but never merged to main. This adds it with an
updated schedule (08:45/20:45 UTC) to maintain a 2h15m gap from the
GPU Training Test (06:30/18:30 UTC), ensuring the two H100 x2 jobs
don't compete for the same runner.
Schedule layout (all 2x daily, 12h apart):
- T4 Smoke: 06:00 / 18:00 UTC
- H100 Inference: 06:15 / 18:15 UTC
- H100 Training x2: 06:30 / 18:30 UTC
- H100 Conformance: 08:45 / 20:45 UTC (2h15m after training)
Aligned with current CI patterns:
- gpu-snapshot-validate action instead of inline snapshot steps
- Karpenter nodepool.yaml applied after install
- load-versions + setup-build-tools for chainsaw install
- Dockerfile.validator and missing action paths in path triggers
- Step ordering and naming consistent with inference/training
- Removed redundant DRA/gang pre-deploy steps that would exhaust
GPU claim capacity before the self-contained conformance checks
run inside aicr validate (introduced in PRs #184, #185)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
countAvailableGPUs()shared helper inconformance/helpers.gofor reuse by other GPU-dependent checksTest plan