feat: add conformance evidence renderer and fix check false-positives#187
Merged
dims merged 1 commit intoNVIDIA:mainfrom Feb 23, 2026
Merged
Conversation
dims
force-pushed
the
feat/evidence-renderer-conformance-fixes
branch
from
50238ad to
40cd575
Compare
Add CNCF AI Conformance evidence rendering to `aicr validate`: - New `--evidence-dir` flag generates per-check markdown evidence files when used with `--phase conformance` - New `--result` flag renders evidence from a saved validation result - New `pkg/evidence` package with templates, types, and renderer - Each conformance check now declares evidence metadata (EvidenceFile, SubmissionRequirement, TestName) in the check registry - Checks in --no-cluster mode report "skipped" instead of "pass" Fix false-positive paths in 5 conformance checks: - cluster-autoscaling: capture baseline Karpenter node count before creating test resources; only count Running/Succeeded pods as scheduled (not Failed/Unknown) - gang-scheduling: verify PodScheduled timestamps are within a co-scheduling window (30s) to prove gang semantics - pod-autoscaling: add scale-down verification after scale-up by patching HPA target to unreachable value and confirming replica reduction (with 0s stabilization window for fast feedback) - robust-controller: replace brittle string matching with k8serrors type predicates (IsForbidden/IsInvalid) for webhook rejection detection, with explicit RBAC exclusion Update H100 GPU CI workflows to upload conformance evidence artifacts alongside validation results.
dims
force-pushed
the
feat/evidence-renderer-conformance-fixes
branch
from
40cd575 to
ef7529e
Compare
This was referenced Feb 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aicr validatevia new--evidence-dirand--resultflagspkg/evidencepackage generates per-check markdown evidence files from conformance validation resultsTest plan
-racepkg/evidencerenderer tests passregistration_test.gomake testpasses (73.4% coverage)make qualifypasses (pre-existing lint config issue only)