feat(conformance): capture observed state in evidence artifacts#204
Merged
dims merged 1 commit intoNVIDIA:mainfrom Feb 25, 2026
Merged
Conversation
090e287 to
2cc21ca
Compare
1f3188a to
9716d10
Compare
Replace hardcoded congratulatory strings in conformance evidence artifacts with actual observed cluster state. Each behavioral check now returns a typed report struct capturing real values (HPA desired/current replicas, node counts, scheduling timestamps, webhook rejection codes, etc.). Also fixes TestSecureAcceleratorAccess flaky failure on GPU Inference CI by: - Pinning the no-claim isolation pod to the GPU node via NodeName, ensuring isolation is proven on a node that actually has GPUs and bypassing scheduler-level delays - Adding podStuckReason() helper for fast failure on ImagePullBackOff, CrashLoopBackOff, and Unschedulable states - Treating K8s client rate limiter errors as retriable - Pinning busybox image to 1.37 (matching HPA tests) - Adding diagnostic output (phase, container status, node) to timeout error messages Deduplicates waitForHPAScalingIntent / waitForClusterAutoHPAScale into a shared waitForHPAScaleUp helper in helpers.go.
8bf599c to
91919ca
Compare
Collaborator
Author
|
Fixing comments from @mchmarny in #201 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
go test -race ./pkg/validator/...passes locally