feat(validator): accept --phase readiness as standalone CLI option#346
Closed
xdu31 wants to merge 1 commit intoNVIDIA:mainfrom
Closed
feat(validator): accept --phase readiness as standalone CLI option#346xdu31 wants to merge 1 commit intoNVIDIA:mainfrom
xdu31 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--phase readinessas a selectable CLI option so users can validate recipe constraints against the snapshot before deployingrunReadinessPhase()replaces the oldcheckReadiness(), serving both explicit and implicit paths--phase allbehavior unchanged: readiness runs as an implicit pre-flight gateMotivation
V2 removed
--phase readinessas a selectable option, breaking the CUJ1 workflow where users validate readiness standalone before deploying. This PR adds it back without duplicating logic.Behavior
--phase readiness--phase readiness,deployment--phase all(default)Changes
pkg/validator/phases.goPhaseReadinessconstantpkg/validator/validator.gocheckReadiness()withrunReadinessPhase(), updateValidatePhases()pkg/cli/validate.gopkg/cli/validate_test.gopkg/validator/validator_test.gocheckReadinesstests withrunReadinessPhaseequivalentsTest plan
go test -race ./pkg/validator/...passesgo test -race ./pkg/cli/...passes--phase readinessaccepted by CLI parser--phase allbehavior unchanged (implicit readiness gate)