feat(bundler): add pre-flight checks to deploy.sh and post-flight to undeploy.sh#364
Open
yuanchen8911 wants to merge 1 commit intoNVIDIA:mainfrom
Open
feat(bundler): add pre-flight checks to deploy.sh and post-flight to undeploy.sh#364yuanchen8911 wants to merge 1 commit intoNVIDIA:mainfrom
yuanchen8911 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
yuanchen8911
force-pushed
the
feat/deploy-preflight-checks
branch
from
6676a4a to
5d75b1b
Compare
…undeploy.sh deploy.sh now runs pre-flight checks before installing components: - Detects terminating namespaces that overlap with bundle components - Detects stale mutating/validating webhooks whose backing services no longer exist (blocks pod creation with fail-closed webhooks) - Detects unavailable API services (blocks namespace deletion) - Aborts with actionable fix instructions if issues are found undeploy.sh now runs post-flight verification after cleanup: - Warns about remaining terminating namespaces - Warns about stale webhooks missed by the orphan cleanup - Warns about unavailable API services - Reports clean/dirty state for subsequent deploy.sh These checks prevent silent deployment failures caused by stale cluster-scoped resources from a previous install/uninstall cycle.
yuanchen8911
force-pushed
the
feat/deploy-preflight-checks
branch
from
5d75b1b to
3edb19d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add pre-flight safety checks to
deploy.shand post-flight verification toundeploy.shto prevent silent deployment failures caused by stale cluster-scoped resources from a previous install/uninstall cycle.Problem
When
undeploy.shor manualhelm uninstallleaves behind stale webhooks, terminating namespaces, or unavailable API services, a subsequentdeploy.shfails silently:custom.metrics.k8s.iofrom prometheus-adapter) block namespace deletionChanges
deploy.sh pre-flight checks
undeploy.sh post-flight verification
Test plan
deploy.shcontains pre-flight sectionundeploy.shcontains post-flight sectionjqfor webhook inspection (gracefully skipped if missing)