Conversation
Coverage Report ✅
Coverage BadgeMerging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
d033d8c to
e661c24
Compare
27d509e to
24165de
Compare
Contributor
|
prealloc lint fix — Line 221 in components_test.go changes allPaths := []string{} to var allPaths []string |
valcharry
reviewed
Feb 10, 2026
c86d82a to
8f1228f
Compare
88c4641 to
39c0adf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add build spec types, YAML parsing, validation, and status writeback for the new
eidos buildcommand, plus declarative value mapping from clusterSpec fields to component overrides.Motivation / Context
The runtime controller needs Eidos to provide a
buildsubcommand that reads a spec file, generates OCI artifacts, and writes image references back. This MR is the foundation: spec file I/O and a declarativeresolver that translates clusterSpec fields into bundler-compatible value overrides. No templates involved — just a YAML config that maps source paths to target paths.
Fixes: HIPPO-4068
Related: ADR-0013, ADR-0018
Type of Change
Component(s) Affected
cmd/eidos,pkg/cli)cmd/eidosd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)pkg/build(new package)Implementation Notes
BuildSpectypes match the runtime controller'sDGXCRuntimestruct (apiVersion,kind,spec,status) so the two can read each other's files.ValueResolverreads amapping.yamlembedded viaembed.FS. New mappings are just YAML — no code changes needed.map[string]map[string]string, which plugs straight intoconfig.WithValueOverrides().mapping.yamlhas two example entries for now. Real mappings get added as we integrate.Testing
Covers: loading, field validation, writeback round-trip, clusterSpec extraction, nested path traversal, conditional mappings, embedded config loading.
Risk Assessment
Rollout notes: N/A
Checklist