chore: Carbide on macOS maintenance to operate with local carbide-rest#449
Open
pbreton wants to merge 9 commits intoNVIDIA:mainfrom
Open
chore: Carbide on macOS maintenance to operate with local carbide-rest#449pbreton wants to merge 9 commits intoNVIDIA:mainfrom
pbreton wants to merge 9 commits intoNVIDIA:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves macOS local development for carbide-api, aiming to run the API locally while allowing access from a locally running carbide-rest (e.g., in kind) via TLS/gRPC.
Changes:
- Adds a macOS helper script to start Vault + Postgres and run
carbide-api. - Switches the macOS
carbide-apiconfig tolisten_mode = "tls"and updates TLS cert paths. - Updates localhost certificates and cert generation to include
host.docker.internal(and Docker Desktop host IP) in SANs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| dev/mac-local-dev/run-carbide-api.sh | New macOS bootstrap script for Vault/Postgres + migrations + running carbide-api. |
| dev/mac-local-dev/carbide-api-config.toml | Enables TLS listen mode and switches TLS file paths (now relative). |
| dev/certs/localhost/gen-certs.sh | Adds SAN entries for host.docker.internal and 192.168.65.254 for macOS Docker Desktop connectivity. |
| dev/certs/localhost/localhost.crt | Updates server cert to match the new SAN set. |
| dev/certs/localhost/client.crt | Updates client cert to match the new SAN set. |
| dev/certs/localhost/ca.crt | Updates CA certificate used for local cert chain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
pbreton
force-pushed
the
chore/carbide-on-mac
branch
2 times, most recently
from
3164b1b to
da5db04
Compare
Signed-off-by: Patrice Breton <pbreton@nvidia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: pbreton <pbreton@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: pbreton <pbreton@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: pbreton <pbreton@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: pbreton <pbreton@users.noreply.github.com>
Signed-off-by: Patrice Breton <pbreton@nvidia.com>
Signed-off-by: Patrice Breton <pbreton@nvidia.com>
Signed-off-by: Patrice Breton <pbreton@nvidia.com>
Signed-off-by: Patrice Breton <pbreton@nvidia.com>
pbreton
force-pushed
the
chore/carbide-on-mac
branch
from
1828ad3 to
663b68a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a script to start Carbide API on macOS with dependencies.
Update certs to allow access to from Carbide REST running locally in kind.
Update macOS config to allow gRPC+HTTPS (TLS) to allow local access to Web UI.
Type of Change
Breaking Changes: NO.
Testing