chore: Set x86 qcow imager to 24.04 & add packages#459
chore: Set x86 qcow imager to 24.04 & add packages#459jdubs wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
a1b5641 to
68fcafc
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the qcow-imager mkosi profiles to align the x86_64 build with Ubuntu 24.04 (matching arm64), adds a few missing tooling packages, enables zstd compression for the produced artifacts, and introduces Makefile tasks to build qcow-imager per-architecture without running the full scout/BFB pipeline.
Changes:
- Switch
qcow-imager(x86_64) mkosi profile from Debian bookworm → Ubuntu noble (24.04), update repositories, and adjust kernel package selection. - Add missing packages (e.g.,
efibootmgr,iproute2,file) and removeSandboxTrees=mkosi.aptfrom the arm64 qcow-imager profile. - Add
build-qcow-imager-x86andbuild-qcow-imager-aarch64tasks inpxe/Makefile.tomlfor standalone per-arch builds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pxe/mkosi.profiles/qcow-imager/mkosi.conf |
Moves x86 qcow-imager to Ubuntu 24.04, enables zstd compression, and updates/adds required packages. |
pxe/mkosi.profiles/qcow-imager-aarch64/mkosi.conf |
Removes SandboxTrees and adds missing packages for parity with other profiles. |
pxe/Makefile.toml |
Adds dedicated per-architecture qcow-imager build tasks to avoid triggering the full build pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Any reason we're moving to ubuntu for the x86 one, instead of moving to debian for the aarch64 one? All things being equal I think we'd prefer debian, if only because the image is less than 1/3 the size... |
|
I was debating on that too, I figured since arm64 was newer and was built with Ubuntu, that's probably the preferred route going forward. I can modify this MR and test using Debian 11 on arm64 or I could take both images to Debian 12. Which would you prefer? |
|
After discussing with Ken, we decided to merge this since moving the arm64 qcow imager to debian might create complexities due to different drivers. |
f2f363a to
db15c3b
Compare
|
I changed the to linux-image-virtual which reduced the size of the qcow image to about 140mb. I did not find any loss of functionality during the qcow imaging process. I tested this change on the following instance types |
Signed-off-by: John Trenholm <jtrenholm@nvidia.com>
Signed-off-by: John Trenholm <jtrenholm@nvidia.com>
03f3797 to
f48866e
Compare
Description
New images:
Old Images:
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes
removed the SandboxTrees=mkosi.apt setting