Skip to content

chore: Set x86 qcow imager to 24.04 & add packages#459

Open
jdubs wants to merge 3 commits intoNVIDIA:mainfrom
jdubs:update_efi_qcow_image
Open

chore: Set x86 qcow imager to 24.04 & add packages#459
jdubs wants to merge 3 commits intoNVIDIA:mainfrom
jdubs:update_efi_qcow_image

Conversation

@jdubs
Copy link

@jdubs jdubs commented Mar 5, 2026

Description

  • Updates the qcow-imager EFI image build configuration from Debian Bookworm to Ubuntu Noble (24.04) matching the arm64 qcow imager
  • adds missing packages to both x86_64 and aarch64 profiles, removed duplicate packages and alphabetized the list.
  • convenience Makefile tasks (build-qcow-imager-x86 and build-qcow-imager-aarch64) for building each architecture independently without scout/BFB.

New images:

  • arm64 - qcow-imager.efi ~ 191M
  • x86 - qcow-imager.efi ~ 148M

Old Images:

  • arm64 - qcow-imager.efi ~ 879M
  • x86 - qcow-imager.efi ~ 235M - bookworm

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains no breaking changes

Testing

  • Manual testing performed

Additional Notes

  • x86_64 profile: switched base from debian:bookworm → ubuntu:noble, swapped linux-image-amd64 → linux-image-generic, added efibootmgr, file, and iproute2 packages, enabled zstd (level 19) output compression, and
    removed the SandboxTrees=mkosi.apt setting
  • aarch64 profile: added efibootmgr and iproute2 packages, removed SandboxTrees=mkosi.apt
  • New build-qcow-imager-x86 and build-qcow-imager-aarch64 Makefile tasks allow building a single architecture's imager EFI without triggering the full scout/BFB pipeline

@jdubs jdubs requested a review from a team as a code owner March 5, 2026 21:05
Copilot AI review requested due to automatic review settings March 5, 2026 21:05
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the qcow-imager mkosi profiles to align the x86_64 build with Ubuntu 24.04 (matching arm64), adds a few missing tooling packages, enables zstd compression for the produced artifacts, and introduces Makefile tasks to build qcow-imager per-architecture without running the full scout/BFB pipeline.

Changes:

  • Switch qcow-imager (x86_64) mkosi profile from Debian bookworm → Ubuntu noble (24.04), update repositories, and adjust kernel package selection.
  • Add missing packages (e.g., efibootmgr, iproute2, file) and remove SandboxTrees=mkosi.apt from the arm64 qcow-imager profile.
  • Add build-qcow-imager-x86 and build-qcow-imager-aarch64 tasks in pxe/Makefile.toml for standalone per-arch builds.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pxe/mkosi.profiles/qcow-imager/mkosi.conf Moves x86 qcow-imager to Ubuntu 24.04, enables zstd compression, and updates/adds required packages.
pxe/mkosi.profiles/qcow-imager-aarch64/mkosi.conf Removes SandboxTrees and adds missing packages for parity with other profiles.
pxe/Makefile.toml Adds dedicated per-architecture qcow-imager build tasks to avoid triggering the full build pipeline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kensimon
Copy link
Contributor

kensimon commented Mar 6, 2026

Any reason we're moving to ubuntu for the x86 one, instead of moving to debian for the aarch64 one? All things being equal I think we'd prefer debian, if only because the image is less than 1/3 the size...

@jdubs
Copy link
Author

jdubs commented Mar 6, 2026

I was debating on that too, I figured since arm64 was newer and was built with Ubuntu, that's probably the preferred route going forward. I can modify this MR and test using Debian 11 on arm64 or I could take both images to Debian 12. Which would you prefer?

@jdubs
Copy link
Author

jdubs commented Mar 6, 2026

After discussing with Ken, we decided to merge this since moving the arm64 qcow imager to debian might create complexities due to different drivers.

@jdubs jdubs force-pushed the update_efi_qcow_image branch from f2f363a to db15c3b Compare March 6, 2026 22:48
@jdubs
Copy link
Author

jdubs commented Mar 6, 2026

I changed the to linux-image-virtual which reduced the size of the qcow image to about 140mb. I did not find any loss of functionality during the qcow imaging process.

I tested this change on the following instance types
supermicro super-grace
gb200
cpu.x86_64
gpu.l40x8.ovx.t1.ibx2

jdubs added 2 commits March 6, 2026 16:55
Signed-off-by: John Trenholm <jtrenholm@nvidia.com>
Signed-off-by: John Trenholm <jtrenholm@nvidia.com>
@jdubs jdubs force-pushed the update_efi_qcow_image branch 2 times, most recently from 03f3797 to f48866e Compare March 6, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants