feat: use health-override instead of hardware health#518
Conversation
Signed-off-by: ianisimov <ianisimov@nvidia.com>
Signed-off-by: ianisimov <ianisimov@nvidia.com>
Signed-off-by: ianisimov <ianisimov@nvidia.com>
Signed-off-by: ianisimov <ianisimov@nvidia.com>
Signed-off-by: ianisimov <ianisimov@nvidia.com>
crates/api-db/migrations/20260311022301_delete_hardware_health_health_column.sql
Show resolved
Hide resolved
crates/api-model/src/machine/mod.rs
Outdated
| .into_iter() | ||
| .filter(|(hr, _)| { | ||
| !HealthReportOverrides::is_hardware_health_override_source(&hr.source) | ||
| }) |
There was a problem hiding this comment.
why remove the hardware reports?
There was a problem hiding this comment.
Good question, at fist i assummed overrides here expected to be only one set by operator. But there is no other source of reports after removal of hardware_health_report, so this filter most likely uncessery.
There was a problem hiding this comment.
+1. I don't understand why it wouldn't be listed.
There was a problem hiding this comment.
It was a mistake, i added it to keep test behavior the same, but from functional point of view we now using override for hardware_health, so it would not need to be filtered.
There was a problem hiding this comment.
Ok. Just asking becasue the change is still there :)
crates/api-model/src/machine/mod.rs
Outdated
| .into_iter() | ||
| .filter(|(hr, _)| { | ||
| !HealthReportOverrides::is_hardware_health_override_source(&hr.source) | ||
| }) |
There was a problem hiding this comment.
+1. I don't understand why it wouldn't be listed.
Signed-off-by: ianisimov <ianisimov@nvidia.com>
Signed-off-by: ianisimov <ianisimov@nvidia.com>
Signed-off-by: ianisimov <ianisimov@nvidia.com>
Signed-off-by: ianisimov <ianisimov@nvidia.com>
Signed-off-by: ianisimov <ianisimov@nvidia.com>
3 participants
Description
With Health-Override API, Hardware-Health API become obsolete. This PR removes this API and moves health service to use overrides instead
Type of Change
Related Issues (Optional)
Breaking Changes
HardwareHealthReport API removed
Testing
Additional Notes