Closed
Conversation
Add an instance ID label to the nvlink config apply latency metric, for more granular alerting. Signed-off-by: Thomas McRoberts <tmcroberts@nvidia.com>
🛡️ Vulnerability Scan🚨 Found 74 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-11 16:44:25 UTC | Commit: 0f78094 |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-11 16:44:25 UTC | Commit: 0f78094 |
rtamma-nv
approved these changes
Mar 11, 2026
Matthias247
reviewed
Mar 11, 2026
| for (duration_ms, instance_id) in &metrics.nvlink_config_apply_durations_ms { | ||
| self.nvlink_config_apply_latency.record( | ||
| *duration_ms, | ||
| &[KeyValue::new("instance_id", instance_id.clone())], |
Contributor
There was a problem hiding this comment.
this will lead to a lot of time-series. e.g. in a site with 1000 instances, you would get 1000 * amount_of_histogram_buckets new lines in the prometheus metrics file.
I'd avoid it, and think about how we can communicate high-latency issues in a different fashion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an instance ID label to the nvlink config apply latency metric, for more granular alerting.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes