fix: standardize machine validation test naming to lowercase#525
Open
chet wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: standardize machine validation test naming to lowercase#525chet wants to merge 1 commit intoNVIDIA:mainfrom
chet wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
This *should* of what @sunilkumar-nvidia was looking for in NVIDIA#456. I wasn't sure if the idea was to standardize/sanitize on inputs, OR within existing values, so it actually seemed to make sense to have it on both, so we didn't have to do any sort of cleanup. First, this will sanitize inputs at input boundaries, where: - `allowed_tests` is lowercased in the admin CLI and API. - `generate_test_id` now lowercases the name so we have consistent IDs. And then, we'll convert values on-demand for a bit of backwards-compatibility + defense-in-depth, where: - SQL queries have been updated to use `LOWER()` for string comparisons. - Test filtering (in `allowed_tests`) now uses case-insensitive matching. Tests added as well to check for the new behaviors, including the SQL query changes. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
wminckler
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This starts to take care of what @sunilkumar-nvidia was looking for in #456. Seemed good to make some progress.
I wasn't sure if the idea was to standardize/sanitize on inputs, OR within existing values, so it actually seemed to make sense to have it on both, so we didn't have to do any sort of cleanup.
First, this will sanitize inputs at input boundaries, where:
allowed_testsis lowercased in the admin CLI and API.generate_test_idnow lowercases the name so we have consistent IDs.And then, we'll convert values on-demand for a bit of backwards-compatibility + defense-in-depth, where:
LOWER()for string comparisons.allowed_tests) now uses case-insensitive matching.Tests added as well to check for the new behaviors, including the SQL query changes.
Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes