fix: Added support for listing IB interfaces by hwadekar-nv · Pull Request #218 · NVIDIA/bare-metal-manager-rest

hwadekar-nv · 2026-03-09T20:40:21Z

Description

Added support for listing InfiniBand (IB) interfaces with filtering capabilities.

Enabled querying IB interfaces by InstanceID
Enabled querying IB interfaces by InfiniBandPartitionID

Type of Change

Feature - New feature or functionality (feat:)
Fix - Bug fixes (fix:)
Chore - Modification or removal of existing functionality (chore:)
Refactor - Refactoring of existing functionality (refactor:)
Docs - Changes in documentation or OpenAPI schema (docs:)
CI - Changes in Github workflows. Requires additional scrutiny (ci:)
Version - Issuing a new release version (version:)

Services Affected

API - API models or endpoints updated
Workflow - Workflow service updated
DB - DB DAOs or migrations updated
Site Manager - Site Manager updated
Cert Manager - Cert Manager updated
Site Agent - Site Agent updated
RLA - RLA service updated
Powershelf Manager - Powershelf Manager updated

Related Issues (Optional)

Breaking Changes

This PR contains breaking changes

Testing

Unit tests added/updated
Integration tests added/updated
Manual testing performed
No testing required (docs, internal refactor, etc.)

Additional Notes

copy-pr-bot · 2026-03-09T20:40:25Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

github-actions · 2026-03-09T20:44:05Z

🔐 TruffleHog Secret Scan

✅ No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

_{🕐 Last updated: 2026-03-09 23:22:05 UTC | Commit: aa8260b}

github-actions · 2026-03-09T20:44:55Z

🛡️ Vulnerability Scan

🚨 Found 64 vulnerability(ies)
📊 vs main: 64 (no change)

Severity Breakdown:

🔴 Critical/High: 64
🟡 Medium: 0
🔵 Low/Info: 0

📋 Top Vulnerabilities

AVD-KSV-0109: Artifact: deploy/kustomize/base/api/configmap.yaml
Type: kubernetes
Vulnerability AVD-KSV-0109
Severity: HIGH
Message: ConfigMap 'carbide-rest-api-config' in 'default' namespace stores secrets in key(s) or value(s) '{" password"}'
Link: AVD-KSV-0109 (deploy/kustomize/base/api/configmap.yaml)
KSV014: Artifact: deploy/kustomize/base/api/deployment.yaml
Type: kubernetes
Vulnerability KSV014
Severity: HIGH
Message: Container 'api' of Deployment 'carbide-rest-api' should set 'securityContext.readOnlyRootFilesystem' to true
Link: KSV014 (deploy/kustomize/base/api/deployment.yaml)
KSV118: Artifact: deploy/kustomize/base/api/deployment.yaml
Type: kubernetes
Vulnerability KSV118
Severity: HIGH
Message: container carbide-rest-api in default namespace is using the default security context
Link: KSV118 (deploy/kustomize/base/api/deployment.yaml)
KSV118: Artifact: deploy/kustomize/base/api/deployment.yaml
Type: kubernetes
Vulnerability KSV118
Severity: HIGH
Message: deployment carbide-rest-api in default namespace is using the default security context, which allows root privileges
Link: KSV118 (deploy/kustomize/base/api/deployment.yaml)
KSV014: Artifact: deploy/kustomize/base/db/job.yaml
Type: kubernetes
Vulnerability KSV014
Severity: HIGH
Message: Container 'migrations' of Job 'carbide-rest-db-migration' should set 'securityContext.readOnlyRootFilesystem' to true
Link: KSV014 (deploy/kustomize/base/db/job.yaml)
KSV014: Artifact: deploy/kustomize/base/db/job.yaml
Type: kubernetes
Vulnerability KSV014
Severity: HIGH
Message: Container 'wait-for-postgres' of Job 'carbide-rest-db-migration' should set 'securityContext.readOnlyRootFilesystem' to true
Link: KSV014 (deploy/kustomize/base/db/job.yaml)
KSV118: Artifact: deploy/kustomize/base/db/job.yaml
Type: kubernetes
Vulnerability KSV118
Severity: HIGH
Message: container carbide-rest-db-migration in default namespace is using the default security context
Link: KSV118 (deploy/kustomize/base/db/job.yaml)
KSV118: Artifact: deploy/kustomize/base/db/job.yaml
Type: kubernetes
Vulnerability KSV118
Severity: HIGH
Message: container carbide-rest-db-migration in default namespace is using the default security context
Link: KSV118 (deploy/kustomize/base/db/job.yaml)
KSV118: Artifact: deploy/kustomize/base/db/job.yaml
Type: kubernetes
Vulnerability KSV118
Severity: HIGH
Message: job carbide-rest-db-migration in default namespace is using the default security context, which allows root privileges
Link: KSV118 (deploy/kustomize/base/db/job.yaml)
KSV014: Artifact: deploy/kustomize/base/keycloak/deployment.yaml
Type: kubernetes
Vulnerability KSV014
Severity: HIGH
Message: Container 'keycloak' of Deployment 'keycloak' should set 'securityContext.readOnlyRootFilesystem' to true
Link: KSV014 (deploy/kustomize/base/keycloak/deployment.yaml)

🔗 View full details in Security tab

_{🕐 Last updated: 2026-03-09 20:44:54 UTC | Commit: 4c5c0ef}

github-actions · 2026-03-09T20:50:53Z

Test Results

7 798 tests +47 7 798 ✅ +47 8m 7s ⏱️ +20s
136 suites ± 0 0 💤 ± 0
14 files ± 0 0 ❌ ± 0

Results for commit 22f5364. ± Comparison against base commit 58e03a0.

♻️ This comment has been updated with latest results.

api/pkg/api/handler/infinibandinterface.go

openapi/spec.yaml

api/pkg/api/handler/infinibandinterface.go

openapi/spec.yaml

api/pkg/api/handler/infinibandinterface.go

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

thossain-nv · 2026-03-11T22:34:41Z

openapi/spec.yaml

+        - schema:
+            type: string
+            enum:
+              - NAME_ASC


InfiniBand Interfaces don't have name attribute, these 2 need to be removed.

thossain-nv · 2026-03-11T22:41:21Z

api/pkg/api/handler/nvlinkinterface.go

+
+	c.Request().URL.RawQuery = q.Encode()
+
+	delegate := NewGetAllNVLinkInterfaceHandler(ganvliih.dbSession, ganvliih.tc, ganvliih.cfg)


When we do this delegation and the Instance ID is non-existent or doesn't belong to Tenant, user will receive messages like Invalid Instance ID in query and be confused as to why we are saying they sent something in query.

Previously I suggested that NewGetAllNVLinkInterfaceHandler can have an explicit argument queryOverride instead of modifying the request object. Based on values int he query override, we can change message tone and skip some checks etc.

thossain-nv · 2026-03-11T23:08:40Z

api/pkg/api/handler/infinibandinterface.go

+				TenantIDs: []uuid.UUID{tenant.ID},
+				SiteIDs:   siteIDs,
+			},
+			cdbp.PageInput{},


Needs total limit.

hwadekar-nv requested review from kunzhao-nv and thossain-nv March 9, 2026 20:40

hwadekar-nv self-assigned this Mar 9, 2026

hwadekar-nv force-pushed the fix/ib-interface branch 2 times, most recently from 1e35723 to 4c5c0ef Compare March 9, 2026 20:42

hwadekar-nv requested review from kfelternv, parmani-nv and pbreton March 9, 2026 21:41

hwadekar-nv force-pushed the fix/ib-interface branch from 09931ff to aa8260b Compare March 9, 2026 23:20

thossain-nv reviewed Mar 9, 2026

View reviewed changes

api/pkg/api/handler/infinibandinterface.go Outdated Show resolved Hide resolved

api/pkg/api/handler/infinibandinterface.go Outdated Show resolved Hide resolved

api/pkg/api/handler/infinibandinterface.go Outdated Show resolved Hide resolved

openapi/spec.yaml Show resolved Hide resolved

hwadekar-nv force-pushed the fix/ib-interface branch 3 times, most recently from 0e2d51a to 078680f Compare March 10, 2026 16:46

thossain-nv reviewed Mar 10, 2026

View reviewed changes

api/pkg/api/handler/infinibandinterface.go Show resolved Hide resolved

api/pkg/api/handler/infinibandinterface.go Show resolved Hide resolved

hwadekar-nv force-pushed the fix/ib-interface branch 4 times, most recently from 89b2703 to f9e6de9 Compare March 11, 2026 21:59

thossain-nv reviewed Mar 11, 2026

View reviewed changes

openapi/spec.yaml Outdated Show resolved Hide resolved

api/pkg/api/handler/infinibandinterface.go Outdated Show resolved Hide resolved

hwadekar-nv force-pushed the fix/ib-interface branch from eecbb30 to 848940c Compare March 11, 2026 22:32

hwadekar-nv added 6 commits March 11, 2026 15:33

fix: Added support for listing IB interfaces

83c7eca

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

Added InstanceID in IB Interface model

104f2fb

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

Efficient pattern for looping query parameter

d55a69b

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

Improve code and added handler for Instance Interfaces

55ddae8

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

Added routes for Instance InfiniBand and NVLink Interfaces

700f8a6

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

Fixed rebase issue

25016ba

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

Addressed review comments

22f5364

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

hwadekar-nv force-pushed the fix/ib-interface branch from 848940c to 22f5364 Compare March 11, 2026 22:33

thossain-nv reviewed Mar 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Added support for listing IB interfaces#218

fix: Added support for listing IB interfaces#218
hwadekar-nv wants to merge 7 commits intomainfrom
fix/ib-interface

hwadekar-nv commented Mar 9, 2026 •

edited

Loading

Uh oh!

copy-pr-bot bot commented Mar 9, 2026

Uh oh!

github-actions bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

github-actions bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thossain-nv Mar 11, 2026

Uh oh!

thossain-nv Mar 11, 2026

Uh oh!

thossain-nv Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		c.Request().URL.RawQuery = q.Encode()

		delegate := NewGetAllNVLinkInterfaceHandler(ganvliih.dbSession, ganvliih.tc, ganvliih.cfg)

Conversation

hwadekar-nv commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Services Affected

Related Issues (Optional)

Breaking Changes

Testing

Additional Notes

Uh oh!

copy-pr-bot bot commented Mar 9, 2026

Uh oh!

github-actions bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔐 TruffleHog Secret Scan

Uh oh!

github-actions bot commented Mar 9, 2026

🛡️ Vulnerability Scan

Uh oh!

github-actions bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thossain-nv Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

thossain-nv Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

thossain-nv Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hwadekar-nv commented Mar 9, 2026 •

edited

Loading

github-actions bot commented Mar 9, 2026 •

edited

Loading

github-actions bot commented Mar 9, 2026 •

edited

Loading