Skip to content

fix: Omit terminating DPU Ext. Service deployments in update request to Site#219

Merged
thossain-nv merged 1 commit intomainfrom
fix/terminating-dpu-ext-svc
Mar 11, 2026
Merged

fix: Omit terminating DPU Ext. Service deployments in update request to Site#219
thossain-nv merged 1 commit intomainfrom
fix/terminating-dpu-ext-svc

Conversation

@thossain-nv
Copy link
Contributor

Description

Currently we are sending DPU Extension Services that are in terminating status to update Instance request to Site. This forces Site to try to recreate the deployment that is terminating and results in failure.

Type of Change

  • Feature - New feature or functionality (feat:)
  • Fix - Bug fixes (fix:)
  • Chore - Modification or removal of existing functionality (chore:)
  • Refactor - Refactoring of existing functionality (refactor:)
  • Docs - Changes in documentation or OpenAPI schema (docs:)
  • CI - Changes in Github workflows. Requires additional scrutiny (ci:)
  • Version - Issuing a new release version (version:)

Services Affected

  • API - API models or endpoints updated
  • Workflow - Workflow service updated
  • DB - DB DAOs or migrations updated
  • Site Manager - Site Manager updated
  • Cert Manager - Cert Manager updated
  • Site Agent - Site Agent updated
  • RLA - RLA service updated
  • Powershelf Manager - Powershelf Manager updated

Related Issues (Optional)

None

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Issue was raised by QA

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 10, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

github-actions bot commented Mar 10, 2026

Test Results

7 753 tests  ±0   7 753 ✅ ±0   8m 13s ⏱️ -5s
  136 suites ±0       0 💤 ±0 
   14 files   ±0       0 ❌ ±0 

Results for commit 9fc2c21. ± Comparison against base commit 724685b.

♻️ This comment has been updated with latest results.

…uest to Site

Signed-off-by: Tareque Hossain <thossain@nvidia.com>
@thossain-nv thossain-nv force-pushed the fix/terminating-dpu-ext-svc branch from 4497778 to 9fc2c21 Compare March 11, 2026 23:06
@github-actions
Copy link

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-03-11 23:07:17 UTC | Commit: 9fc2c21

@github-actions
Copy link

🛡️ Vulnerability Scan

🚨 Found 64 vulnerability(ies)
📊 vs main: 64 (no change)

Severity Breakdown:

  • 🔴 Critical/High: 64
  • 🟡 Medium: 0
  • 🔵 Low/Info: 0

🔗 View full details in Security tab

🕐 Last updated: 2026-03-11 23:07:38 UTC | Commit: 9fc2c21

@thossain-nv thossain-nv merged commit 8fa9a4b into main Mar 11, 2026
51 checks passed
@thossain-nv thossain-nv deleted the fix/terminating-dpu-ext-svc branch March 11, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants