feat: Allow different NVLink partitions for Instance create and update#225
feat: Allow different NVLink partitions for Instance create and update#225hwadekar-nv wants to merge 2 commits intomainfrom
Conversation
491e129 to
d6e3f16
Compare
Signed-off-by: Hitesh Wadekar <[email protected]>
d6e3f16 to
e02c47a
Compare
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-10 18:59:11 UTC | Commit: e02c47a |
🛡️ Vulnerability Scan🚨 Found 64 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-10 18:59:20 UTC | Commit: e02c47a |
Test Results7 588 tests +1 7 588 ✅ +1 8m 3s ⏱️ +6s Results for commit eda4a1b. ± Comparison against base commit 6b7415d. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
| logger.Warn().Msg(fmt.Sprintf("NVLink Logical Partition: %v specified in request does not match with Instance Site", nvllp.ID)) | ||
| return cerr.NewAPIErrorResponse(c, http.StatusBadRequest, fmt.Sprintf("NVLink Logical Partition: %v specified in request does not match with Instance Site", nvllp.ID), nil) | ||
| } | ||
| // Validate each NVLink Logical Partition independently for site, tenant, and status |
There was a problem hiding this comment.
@hwadekar-nv The goal wasn't to alter the behavior when default NVLink Logical Partition is present rather when there is no default. Based on the issue, we should resolve only the restrictions that produce the following error messages:
Description
Type of Change
Services Affected
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes