refactor: Adopt the common.SetupHandler for more handlers#231
Merged
chet merged 2 commits intoNVIDIA:mainfrom Mar 11, 2026
Merged
refactor: Adopt the common.SetupHandler for more handlers#231chet merged 2 commits intoNVIDIA:mainfrom
chet merged 2 commits intoNVIDIA:mainfrom
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-11 03:30:21 UTC | Commit: 583a701 |
🛡️ Vulnerability Scan🚨 Found 64 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-11 03:30:26 UTC | Commit: 583a701 |
chet
changed the title
Sorry, as part of putting up NVIDIA#220, I started digging around to see if there was anything else I could contribute instead of just doing a drive by. I noticed there's this `common.SetupHandler` that exists, and that it *looks* like the idea is to adopt it everywhere, so this does that. It shaves down a bunch of code, and ensures handler setup is standardized. The nice thing was, everything already *was* standardized (just the same lines of setup for each one), so it was an easy migration into this handler. There MAY be a reason nothing was using this yet, but figured I'd toss this up! If it's not the right direction for things, totally feel free to throw it back at me. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
thossain-nv
force-pushed
the
adopt_setup_handler
branch
from
d587dfe to
9abd66a
Compare
Contributor
|
/ok to test 9abd66a |
thossain-nv
approved these changes
Mar 11, 2026
Contributor
thossain-nv
left a comment
thossain-nv
left a comment
There was a problem hiding this comment.
Looks good, thanks @chet Fixed one issue that I found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of putting up #220, I started digging around to see if there was anything else I could contribute instead of just doing a drive by. I noticed there's this
common.SetupHandlerthat exists, and that it looks like the idea is to adopt it everywhere, so this does that. It shaves down a bunch of code, and ensures handler setup is standardized. The nice thing was, everything already was standardized (just the same lines of setup for each one), so it was an easy migration into this handler.I did read the docstring for
SetupHandler, and made sure the criteria are met for the handlers I'm updating.There MAY be a reason nothing was using this yet, but figured I'd toss this up! If it's not the right direction for things, totally feel free to throw it back at me.
Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Services Affected
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes