chore: Support helm deploy on KinD in makefile#232
Open
lachen-nv wants to merge 3 commits intoNVIDIA:mainfrom
Open
chore: Support helm deploy on KinD in makefile#232lachen-nv wants to merge 3 commits intoNVIDIA:mainfrom
lachen-nv wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-11 12:04:46 UTC | Commit: 6bb4192 |
🛡️ Vulnerability Scan🚨 Found 64 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-11 12:04:56 UTC | Commit: 6bb4192 |
kfelternv
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add helm deploy command into the Makefile
Type of Change
Services Affected
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes
Test Report: Helm Deployment via make kind-reset
Environment
Test: make kind-reset (Helm path)
Ran make kind-reset end-to-end on a fresh remote machine. All steps completed successfully:
Final pod status (carbide-rest namespace)
carbide-rest-api 1/1 Running 0
carbide-rest-cert-manager 1/1 Running 0
carbide-rest-cloud-worker 1/1 Running 0
carbide-rest-db-migration 0/1 Completed 0
carbide-rest-mock-core 1/1 Running 0
carbide-rest-site-agent-0 1/1 Running 0
carbide-rest-site-manager 1/1 Running 0
carbide-rest-site-worker 1/1 Running 0
keycloak 1/1 Running 0
Bug found & fixed during testing
Site-agent was CrashLooping after bootstrap.
Root cause: the temporal-client-site-agent-certs secret was not pre-created by the Helm chart, so the bootstrap code's secretIf.Get() returned NotFound and failed. The Kustomize path already
had a placeholder secret (temporal-client-site-agent-certs.yaml) but it was missing from the Helm chart.
Fix: added helm/charts/carbide-rest-site-agent/templates/temporal-certs-secret.yaml as an empty placeholder secret, matching the Kustomize behavior. Also added create verb to the site-agent RBAC Role for completeness.