Skip to content

unskip evo2 tests#1058

Merged
broland-hat merged 22 commits intomainfrom
br_bnm2533_fix_evo2_tests_a
Aug 26, 2025
Merged

unskip evo2 tests#1058
broland-hat merged 22 commits intomainfrom
br_bnm2533_fix_evo2_tests_a

Conversation

@broland-hat
Copy link
Collaborator

@broland-hat broland-hat commented Aug 20, 2025

Description

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe):

CI Pipeline Configuration

Configure CI behavior by applying the relevant labels:

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Authorizing CI Runs

We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.

  • If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will
    automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
  • If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an
    /ok to test comment on the pull request to trigger CI. This will need to be done for each new commit.

Usage

# TODO: Add code snippet

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

Local test runs

the slow test test_evo2.py::test_golden_values_top_k_logits_and_cosine_similarity_7b is broken on main, will be marked skip

the slow test test_evo.py::test_generate_speed is marked skip per https://nvidia.slack.com/archives/C074Z808N05/p1755185565520729?thread_ts=1755097791.370249&cid=C074Z808N05

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@broland-hat broland-hat self-assigned this Aug 20, 2025
Signed-off-by: Brian Roland <broland@nvidia.com>
Signed-off-by: Brian Roland <broland@nvidia.com>
Signed-off-by: Brian Roland <broland@nvidia.com>
Signed-off-by: Brian Roland <broland@nvidia.com>
Signed-off-by: Brian Roland <broland@nvidia.com>
@jstjohn
Copy link
Collaborator

jstjohn commented Aug 20, 2025

/ok to test 9537a47

Signed-off-by: Brian Roland <broland@nvidia.com>
@broland-hat broland-hat marked this pull request as ready for review August 21, 2025 18:16
@pstjohn
Copy link
Collaborator

pstjohn commented Aug 21, 2025

/ok to test 6e2a005

Signed-off-by: Brian Roland <broland@nvidia.com>
Signed-off-by: Brian Roland <broland@nvidia.com>
Signed-off-by: Brian Roland <broland@nvidia.com>
@broland-hat
Copy link
Collaborator Author

/okay to test 2b9ccdb

@jstjohn jstjohn enabled auto-merge August 21, 2025 23:03
Copy link
Collaborator

@farhadrgh farhadrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@broland-hat
Copy link
Collaborator Author

/okay to test 28586e5

@jstjohn jstjohn added this pull request to the merge queue Aug 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2025
@broland-hat broland-hat added this pull request to the merge queue Aug 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2025
@broland-hat broland-hat added this pull request to the merge queue Aug 25, 2025
Signed-off-by: Brian Roland <broland@nvidia.com>
@broland-hat broland-hat removed this pull request from the merge queue due to a manual request Aug 25, 2025
@broland-hat
Copy link
Collaborator Author

/okay to test '628d090'

Signed-off-by: Brian Roland <broland@nvidia.com>
@broland-hat
Copy link
Collaborator Author

/okay to skip 320ed0a

@broland-hat broland-hat enabled auto-merge August 25, 2025 22:14
@broland-hat
Copy link
Collaborator Author

/okay to test 320ed0a

Signed-off-by: Brian Roland <broland@nvidia.com>
@broland-hat
Copy link
Collaborator Author

/okay to test 83f152a

@broland-hat
Copy link
Collaborator Author

/okay to test 1f95151

@broland-hat
Copy link
Collaborator Author

/okay to test 9e85a76

@broland-hat broland-hat added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit fe8d7e6 Aug 26, 2025
16 checks passed
@broland-hat broland-hat deleted the br_bnm2533_fix_evo2_tests_a branch August 26, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants