Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
- Coverage 81.29% 80.83% -0.47%
==========================================
Files 152 153 +1
Lines 10271 10494 +223
==========================================
+ Hits 8350 8483 +133
- Misses 1921 2011 +90
|
Signed-off-by: Steven <skothenhill@nvidia.com>
Signed-off-by: Steven <skothenhill@nvidia.com>
7c4b597 to
2eacb12
Compare
nominally adds block sampling to the geneformer datamodule (probably will change more) adds a small performance script (will change) Signed-off-by: Steven <skothenhill@nvidia.com>
…amework-fresh/bionemo-framework/. into hillst/block-sampling3 Signed-off-by: Steven <skothenhill@nvidia.com>
b2f03c9 to
9b86370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
implements scDataset style block sampling. Map-style and Iter-style are provided, with the license from the original source. We add our internal
permutecalls to ensure rng compatability, and then test for equivalence. Additionally, randomness tests were performed outside the framework to compare the np.permute method with the bionemo internal permute.process_itemin the geneformer Dataset object__getitems__implementations for a few Dataset classes (note that these do nothing unless its the top level class in a Dataloader)Purpose of this work is to test the consequences of block-randomness on model training.
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Usage
# TODO: Add code snippetPre-submit Checklist