-
Notifications
You must be signed in to change notification settings - Fork 126
Initial version porting the eden configs over to the new evo2 recipe #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jstjohn
wants to merge
12
commits into
main
Choose a base branch
from
jstjohn/evo2_llama_configs_and_savanna_convert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0a1c3ce
Initial version porting the eden configs over to the new evo2 recipe
jstjohn ea7fdba
Cleanup the environment between tests
jstjohn 7cd8ede
Work on test failures and making sure we are following mbridge conven…
jstjohn 7761d54
Fix test related to savanna -> mbridge -> vortex checkpoint test
jstjohn 7899f46
Get eden tests passing
jstjohn f9026a0
Merge branch 'main' of github.com:NVIDIA/bionemo-framework into jstjo…
jstjohn 12f01b3
Address PR feedback and adding docs and 20b checkpoint
jstjohn 9e24137
Updates to readme and adding independent scripts for conversion
jstjohn 0cacf51
Add validation for the finetune checkpoint path
jstjohn 4709e95
Cleanup unused commented out code
jstjohn d2dd38b
Fix the parameterization for the 20b model
jstjohn dd0ff70
Update examples
jstjohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a language tag to these new fenced command blocks.
markdownlintwill keep warning on both fences until they use a language identifier.bashfits the surrounding shell examples.💡 Minimal fix
@@
-
+bashStep 1: Savanna -> MBridge
evo2_convert_savanna_to_mbridge
--savanna-ckpt-path arcinstitute/savanna_evo2_1b_base
--mbridge-ckpt-dir /tmp/mbridge_1b
--model-size evo2_1b_base \
Verify each finding against the current code and only fix it if needed.
In
@bionemo-recipes/recipes/evo2_megatron/README.mdaround lines 157 - 162, Adda language identifier (bash) to the fenced code blocks containing the shell
commands (e.g., the blocks that show evo2_export_mbridge_to_vortex and
evo2_convert_savanna_to_mbridge) so markdownlint stops warning; locate the
backtick fences around those command examples and change the opening fence from
tobash for each occurrence (including the second block around theevo2_convert_savanna_to_mbridge example).