Skip to content

README updates, hydra config fix#1507

Open
pstjohn wants to merge 2 commits intoNVIDIA:mainfrom
pstjohn:pstjohn/esm2-recipe-lint
Open

README updates, hydra config fix#1507
pstjohn wants to merge 2 commits intoNVIDIA:mainfrom
pstjohn:pstjohn/esm2-recipe-lint

Conversation

@pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Mar 11, 2026

No description provided.

Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 115f3671-fb31-4bda-9c36-3113cfffbb8e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

tokenizer_name: ???
tokenizer_name: ${config_name_or_path}
micro_batch_size: ???
num_workers: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you able to add use_quantized_weights: null?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will then get passed to the non-TE models, but we could. We'd just have to show that training with the HF models requires deleting this key

Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants