Merged
Conversation
pstjohn
requested review from
dorotat-nv,
jstjohn and
malcolmgreaves
as code owners
Collaborator
Author
|
/build-ci |
cspades
approved these changes
Jan 10, 2025
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
force-pushed
the
pstjohn-patch-2
branch
from
eee3d20 to
3a129fe
Compare
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 89 89
Lines 5758 5758
=======================================
Hits 5052 5052
Misses 706 706 ☔ View full report in Codecov by Sentry. |
jstjohn
approved these changes
Jan 10, 2025
jstjohn
reviewed
Jan 10, 2025
Collaborator
Author
|
/build-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a codecov badge to the README and removes a duplicate pre-commit workflow.
Because jobs can only depend on other jobs in the same workflow file (IIUC), we put the pre-commit workflow in the new azure CI definition. That way, the docker build and test steps only trigger if the pre-commit results pass