Skip to content

Add support for marking and skipping slow tests, temporarily mark pydantic tests as slow#589

Merged
pstjohn merged 7 commits intoNVIDIA:mainfrom
pstjohn:pstjohn/disable-pydantic-tests
Jan 13, 2025
Merged

Add support for marking and skipping slow tests, temporarily mark pydantic tests as slow#589
pstjohn merged 7 commits intoNVIDIA:mainfrom
pstjohn:pstjohn/disable-pydantic-tests

Conversation

@pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Jan 10, 2025

Description

These pydantic CLI tests are currently taking an inordinate amount of time to run. This PR adds support for using pytest.mark.slow to flag tests not to run during pre-merge testing, but will still be run during nightly tests.

Also adds some cleanup to the azure runner test suite to remove the docker container from the GPU runner since these are not ephemeral workers, and updates the cache mounting location for the container job to re-use downloads.

See https://nvidia.slack.com/archives/C074Z808N05/p1736460988702949
https://jirasw.nvidia.com/browse/BIONEMO-553

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe):

CI Pipeline Configuration

Configure CI behavior by checking relevant boxes below. This will automatically apply labels.

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Usage

TODO: Add code snippet

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (c691df2) to head (9480af8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   87.73%   88.78%   +1.04%     
==========================================
  Files          89       81       -8     
  Lines        5758     5027     -731     
==========================================
- Hits         5052     4463     -589     
+ Misses        706      564     -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@pstjohn pstjohn changed the title Temporarily disable pydantic tests Add support for marking slow tests, temporarily mark pydantic tests as slow Jan 10, 2025
@pstjohn pstjohn changed the title Add support for marking slow tests, temporarily mark pydantic tests as slow Add support for marking and skipping slow tests, temporarily mark pydantic tests as slow Jan 10, 2025
pstjohn and others added 5 commits January 10, 2025 16:08
Signed-off-by: Peter St. John <peterc.stjohn@gmail.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <peterc.stjohn@gmail.com>
Signed-off-by: Peter St. John <peterc.stjohn@gmail.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@pstjohn
Copy link
Collaborator Author

pstjohn commented Jan 12, 2025

/build-ci

@pstjohn pstjohn enabled auto-merge (squash) January 12, 2025 23:25
@pstjohn pstjohn requested a review from dorotat-nv January 12, 2025 23:25
@pstjohn pstjohn merged commit b91f4df into NVIDIA:main Jan 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants