Rework hierarchy levels #6957
Open
Rework hierarchy levels #6957
+3,955
−339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
davebayer
force-pushed
the
rework_hierarchy
branch
from
285fc8e to
0913bfc
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
2 times, most recently
from
1696934 to
8e96baa
Compare
pciolkosz
reviewed
Dec 12, 2025
davebayer
force-pushed
the
rework_hierarchy
branch
3 times, most recently
from
378f52f to
ee6e83f
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
from
ee6e83f to
41d720f
Compare
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
rework_hierarchy
branch
from
4974c84 to
c9abf7b
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
from
d1d1d7c to
5a5e93f
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
from
c7176e9 to
f479987
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
from
4acd651 to
000c2eb
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
😬 CI Workflow Results🟥 Finished in 1h 35m: Pass: 98%/123 | Total: 1d 18h | Max: 1h 35m | Hits: 99%/212322See results here. |
pciolkosz
reviewed
Dec 18, 2025
| */ | ||
| template <class _Tp, size_t... _Extents> | ||
| struct hierarchy_query_result : public dimensions<_Tp, _Extents...> | ||
| struct hierarchy_query_result_org : public dimensions<_Tp, _Extents...> |
Contributor
There was a problem hiding this comment.
Should this type be removed?
|
|
||
| _CCCL_TEMPLATE(class _Tp, class _Hierarchy) | ||
| _CCCL_REQUIRES(::cuda::std::__cccl_is_integer_v<_Tp> _CCCL_AND __is_hierarchy_v<_Hierarchy>) | ||
| [[nodiscard]] _CCCL_DEVICE_API static _Tp rank_as(const grid_level& __level, const _Hierarchy& __hier) noexcept |
Contributor
There was a problem hiding this comment.
Is this needed just as an optimization?
| _CCCL_TEMPLATE(class _Tp, class _InLevel, class _Hierarchy) | ||
| _CCCL_REQUIRES(::cuda::std::__cccl_is_integer_v<_Tp> _CCCL_AND __is_hierarchy_level_v<_InLevel> _CCCL_AND | ||
| __is_hierarchy_v<_Hierarchy>) | ||
| [[nodiscard]] _CCCL_API static constexpr auto extents_as(const _InLevel& __in_level, const _Hierarchy& __hier) noexcept |
Contributor
There was a problem hiding this comment.
Why not just return __hier.extents(_Level{}, _InLevel{})?
|
|
||
| _CCCL_TEMPLATE(class _Tp2 = _Tp) | ||
| _CCCL_REQUIRES(::cuda::std::is_same_v<_Tp2, signed char>) | ||
| _CCCL_API constexpr operator char3() const noexcept |
Contributor
There was a problem hiding this comment.
we really need all those operators?
| inline constexpr bool trait_v = cuda::__is_natively_reachable_hierarchy_level_v<FromLevel, ToLevel>; | ||
|
|
||
| static_assert(!trait_v<cuda::thread_level, cuda::thread_level>); | ||
| static_assert(!trait_v<cuda::thread_level, cuda::warp_level>); |
Contributor
There was a problem hiding this comment.
think a query like that should work no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6885