Add _CCCL_DEDUCTION_GUIDE_EXSPACE
#6964
Open
+137
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm a bit hesitant because llvm-22 is still under development. If something change, we need to address the issue. Is the behavior reported on some docs at least? |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Aaah, you are right, the change was added to clang last week :D llvm/llvm-project@03e42c9 But it's well documented and I don't expect it to be changed. |
Contributor
🥳 CI Workflow Results🟩 Finished in 13h 31m: Pass: 100%/211 | Total: 12d 04h | Max: 5h 13m | Hits: 29%/379225See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-cuda has always forced us to add
__host__ __device__annotations to deduction guides. However, since clang-22, this is no longer the case + clang emits ton of warnings about this behaviour being deprecated.This PR introduces
_CCCL_DEDUCTION_GUIDE_EXSPACEmacro that expands to_host__ __device__for clang < 22, otherwise is empty.