Add non-throwing overloads to is_pointer_accessible
#6988
Merged
+120
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a::std::nothrow_t` for `is_host_accessible`, `is_device_accessible`, and `is_managed`.
This comment has been minimized.
This comment has been minimized.
davebayer
requested changes
Dec 16, 2025
Contributor
davebayer
left a comment
davebayer
left a comment
There was a problem hiding this comment.
Can you make them internal for now? If we want to start adding non-throwing variants of our APIs, we need a broader discussion and agree on the strategy.
davebayer
approved these changes
Dec 16, 2025
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 40m: Pass: 100%/91 | Total: 1d 04h | Max: 1h 47m | Hits: 93%/212401See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
is_host_accessible,is_device_accessible, andis_managedthrow exceptions when the underlying driver calls fail.On the other hand, such functions are mostly used in assertion where side effects are not allowed.
This PR introduces non-throwing overloads via
cuda::std::nothrow_ttag dispatch.