Skip to content

Detect non GNU getopt and error early#7866

Merged
bernhardmgruber merged 1 commit intoNVIDIA:mainfrom
Jacobfaib:jacobf/2026-03-03/detect-non-gnu-getopt
Mar 4, 2026
Merged

Detect non GNU getopt and error early#7866
bernhardmgruber merged 1 commit intoNVIDIA:mainfrom
Jacobfaib:jacobf/2026-03-03/detect-non-gnu-getopt

Conversation

@Jacobfaib
Copy link
Contributor

Description

Detect non "enhanced" getopt early in .devcontainer/launch.sh (for example, BSD getopt) and give a more informative error message. BSD getopt for instance does not support long options and will silently skip them leading to strange errors later down the line

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Mar 3, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Mar 3, 2026
@Jacobfaib
Copy link
Contributor Author

Maybe a better approach would be to use the standard getopt builtin, but this requires manually parsing long options and doesn't support fancy options like --option=value (note the =)

@Jacobfaib Jacobfaib force-pushed the jacobf/2026-03-03/detect-non-gnu-getopt branch from 24b9124 to b1dfa1f Compare March 3, 2026 17:16
@Jacobfaib Jacobfaib marked this pull request as ready for review March 3, 2026 17:17
@Jacobfaib Jacobfaib requested a review from a team as a code owner March 3, 2026 17:17
@Jacobfaib Jacobfaib requested a review from jrhemstad March 3, 2026 17:17
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Mar 3, 2026
@Jacobfaib Jacobfaib force-pushed the jacobf/2026-03-03/detect-non-gnu-getopt branch from b1dfa1f to 6670625 Compare March 3, 2026 19:03
@bernhardmgruber
Copy link
Contributor

/ok to test 6670625

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🥳 CI Workflow Results

🟩 Finished in 1h 43m: Pass: 100%/452 | Total: 3d 07h | Max: 1h 43m | Hits: 99%/504982

See results here.

@bernhardmgruber bernhardmgruber merged commit 3288e60 into NVIDIA:main Mar 4, 2026
520 of 521 checks passed
@Jacobfaib Jacobfaib deleted the jacobf/2026-03-03/detect-non-gnu-getopt branch March 4, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants