Support non-copyable stream types in DeviceTransform#7915
Open
bernhardmgruber wants to merge 1 commit intoNVIDIA:mainfrom
Open
Support non-copyable stream types in DeviceTransform#7915bernhardmgruber wants to merge 1 commit intoNVIDIA:mainfrom
DeviceTransform#7915bernhardmgruber wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
This is a fix for another bug introduced in NVIDIA#6204
bernhardmgruber
changed the title
DeviceTransform
miscco
reviewed
Mar 6, 2026
| ::cuda::std::tuple<RandomAccessIteratorsOut...> outputs, | ||
| NumItemsT num_items, | ||
| TransformOp transform_op, | ||
| Env env = {}) |
Contributor
There was a problem hiding this comment.
Strongly wondering whether it wouldnt be better to have an overload that forwards, but we should definitely make a definite decision on what we expect of environements
Contributor
Author
There was a problem hiding this comment.
I think taking the environment by && would work as well here, yes. We should decide this.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 5h 21m: Pass: 100%/249 | Total: 9d 01h | Max: 4h 00m | Hits: 73%/155156See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for another bug introduced in #6204