Add environment overloads for DeviceHistogram::*#7967
Open
gonidelis wants to merge 4 commits intoNVIDIA:mainfrom
Open
Add environment overloads for DeviceHistogram::*#7967gonidelis wants to merge 4 commits intoNVIDIA:mainfrom
DeviceHistogram::*#7967gonidelis wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
gonidelis
changed the title
DeviceHistogram::*
This comment has been minimized.
This comment has been minimized.
gonidelis
requested review from
bernhardmgruber,
gevtushenko and
srinivasyadav18
This comment has been minimized.
This comment has been minimized.
gonidelis
force-pushed
the
histogram_env
branch
from
ff1879f to
f26e09e
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 10m: Pass: 100%/249 | Total: 2d 13h | Max: 1h 00m | Hits: 98%/156447See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7542
Adds environment overloads for
DeviceHistogramHistogram reductions are always on integers. Integer addition is truly associative and commutative (no float ops) Hence, the order of additions doesn't matter. So histogram is always deterministic.
Question to the audience:
Should I take the liberty to guarantee
gpu_to_gpufor DeviceHistogram? @bernhardmgruber @gevtushenkoI guess that may as well just include reporting it in the docs.