Open
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
😬 CI Workflow Results🟥 Finished in 2h 04m: Pass: 15%/249 | Total: 4d 12h | Max: 2h 03m | Hits: 88%/55533See results here. |
Comment on lines
+162
to
+164
| ::cuda::std::enable_if_t<!::cuda::std::is_same_v<KeyIteratorIn1, void*> | ||
| && !::cuda::std::is_same_v<KeyIteratorIn1, ::cuda::std::nullptr_t>, | ||
| int> = 0> |
Contributor
There was a problem hiding this comment.
Remark: that's an interesting constraint since it guards against using the old overload with nullptr. It's fine. You need it here I guess because you cannot constraint a second template argument since it's just int64 here and a size_t from the other overload would convert to int64 well.
Comment on lines
+178
to
+183
| using requested_determinism_t = | ||
| ::cuda::std::execution::__query_result_or_t<requirements_t, | ||
| ::cuda::execution::determinism::__get_determinism_t, | ||
| ::cuda::execution::determinism::run_to_run_t>; | ||
| static_assert(!::cuda::std::is_same_v<requested_determinism_t, ::cuda::execution::determinism::gpu_to_gpu_t>, | ||
| "gpu_to_gpu determinism is not supported for unstable device merge"); |
Contributor
There was a problem hiding this comment.
Important: I need to think about this, since an unstable algorithm could still be deterministic (even across multiple GPUs). How did you conclude that the merge path implementation is run_to_run deterministic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7543