Open
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment has been minimized.
This comment has been minimized.
Comment on lines
+162
to
+164
| ::cuda::std::enable_if_t<!::cuda::std::is_same_v<KeyIteratorIn1, void*> | ||
| && !::cuda::std::is_same_v<KeyIteratorIn1, ::cuda::std::nullptr_t>, | ||
| int> = 0> |
Contributor
There was a problem hiding this comment.
Remark: that's an interesting constraint since it guards against using the old overload with nullptr. It's fine. You need it here I guess because you cannot constraint a second template argument since it's just int64 here and a size_t from the other overload would convert to int64 well.
Member
Author
There was a problem hiding this comment.
we still get an ambiguity:
cub::DeviceMerge::MergeKeys(
thrust::raw_pointer_cast(temp_storage.data()), // KeyIteratorIn1 = char*
temp_storage_bytes, // num_keys1 (size_t -> int64)
keys1.begin(), // KeyIteratorIn2
static_cast<int>(keys1.size()), // num_keys2 (int -> int64)
keys2.begin(), // KeyIteratorOut
static_cast<int>(keys2.size()), // CompareOp = int
result.begin()); // EnvT = iterator
Member
Author
There was a problem hiding this comment.
we need extra constraints
Member
Author
|
After long discussion with @bernhardmgruber we decided not to specify any deterministic guarantees for |
gonidelis
commented
Mar 12, 2026
|
|
||
| // %PARAM% TEST_LAUNCH lid 0:1:2 | ||
|
|
||
| #include <cuda/__execution/require.h> |
Contributor
😬 CI Workflow Results🟥 Finished in 2h 20m: Pass: 99%/249 | Total: 8d 17h | Max: 2h 19m | Hits: 73%/157066See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7543