[HostJit] Windows support#9502
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughWindows JIT compilation is fixed by adding an ChangesWindows JIT compilation and type alias support
OS-aware visibility and attribute macro refactoring
Possibly related PRs
Suggested reviewers
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: eb88a771-d376-4cb3-b893-2479707055a8
📒 Files selected for processing (4)
c/parallel.v2/CMakeLists.txtc/parallel.v2/src/hostjit/compiler.cppc/parallel.v2/src/hostjit/include/hostjit/cuda_minimal/stubs/stdlib.hlibcudacxx/include/cuda/std/cstdint
This comment has been minimized.
This comment has been minimized.
35efdfb to
dc35eef
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 29d027cb-f1de-44fc-b640-3b50620eac8a
📒 Files selected for processing (9)
c/parallel.v2/CMakeLists.txtc/parallel.v2/src/hostjit/codegen/cub_call.cppc/parallel.v2/src/hostjit/compiler.cppc/parallel.v2/src/hostjit/include/hostjit/codegen/cub_call.hppc/parallel.v2/src/hostjit/include/hostjit/cuda_minimal/stubs/stdlib.hlibcudacxx/include/cuda/std/__cccl/attributes.hlibcudacxx/include/cuda/std/__cccl/visibility.hlibcudacxx/include/cuda/std/__internal/features.hlibcudacxx/include/cuda/std/cstdint
✅ Files skipped from review due to trivial changes (3)
- c/parallel.v2/src/hostjit/include/hostjit/codegen/cub_call.hpp
- c/parallel.v2/CMakeLists.txt
- c/parallel.v2/src/hostjit/include/hostjit/cuda_minimal/stubs/stdlib.h
🚧 Files skipped from review as they are similar to previous changes (1)
- c/parallel.v2/src/hostjit/compiler.cpp
I dont even...
…stjit compilation We are running single threaded anyway, and we do not have access to the necessary CRT symbols
😬 CI Workflow Results🟥 Finished in 5h 32m: Pass: 97%/118 | Total: 4d 20h | Max: 4h 19m | Hits: 50%/1119049See results here. |
This is initial work to suppport HostJit on windows.
We need to mostly work around some dll issues with missing symbols.
We are still failing some tests that need to be investigated, but this serves as a good start