Updates for coco 1.1#408
Conversation
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Documentation preview |
| * A Kubernetes cluster with cluster administrator privileges. | ||
| Refer to the :ref:`Supported Software Components <coco-supported-software-components>` table for supported Kubernetes versions. | ||
|
|
||
| * containerd version 2.2.2 installed. |
There was a problem hiding this comment.
Just for me to understand - why are we removing this here? Maybe I don't have the complete oversight right now, and this is listed somewhere else?
There was a problem hiding this comment.
we list it in the platform support page. We added it b/c there was a hard requirement for 2.2.2 being installed. In this release we now support 2.3.
Do you still think it is valuable to call this out to folks here as well as in the support matrix?
There was a problem hiding this comment.
might be a bit confusing. yes, we list containerd in the support matrix but we also list QEMU. While QEMU comes from kata-deploy, containerd doesn't ... so users still need to ensure they have containerd running. Maybe we can collapse this into the prior point about 'A Kubernetes cluster with cluster administrator privileges" => to something like:
"A Kubernetes cluster with cluster administrator privileges using containerd on the nodes", "Refer to the ... table for supported Kubernetes and containerd versions"?
@fidencio thoughts?
There was a problem hiding this comment.
I think we should keep the note about containerd as we know from past experiences that people tend to just ignore when it's not that explicit.
manuelh-dev
left a comment
manuelh-dev
left a comment
There was a problem hiding this comment.
LGTM with 2 minor aspects to discuss
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
There was a problem hiding this comment.
lgtm, thanks @a-mccarthy!
EDITED: Just noticed a few things to change.
| - 10.1 \+ Patches | ||
| * - `Containerd <https://github.com/containerd/containerd>`__ | ||
| - 2.2.2 | ||
| - 2.2.2 or 2.3.x |
| @@ -297,7 +297,6 @@ The minimum required version is 3.29.0. | |||
| $ helm install kata-deploy "${CHART}" \ | |||
There was a problem hiding this comment.
We need to pass that added values.yaml here.
There was a problem hiding this comment.
+1 ... apart from the currently open comments, this PR LGTM
3 participants
No description provided.