Skip to content

Commit 267db18

Browse files
authored
Refactor nodelist validation to check DYNAMO_NODELIST only if both args empty (#658)
1 parent eaba85a commit 267db18

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/cloudai/workloads/ai_dynamo/ai_dynamo.sh

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -532,10 +532,12 @@ validate_environment() {
532532
exit 1
533533
fi
534534

535-
# If both nodelists are empty then DYNAMO_NODELIST must be provided
536-
if [[ -z "${dynamo_args["decode-nodelist"]}" && -z "${dynamo_args["prefill-nodelist"]}" && -z "${DYNAMO_NODELIST:-}" ]]; then
537-
log "ERROR: Provide --dynamo-decode-nodelist/--dynamo-prefill-nodelist or set DYNAMO_NODELIST"
538-
exit 1
535+
# If both nodelists are empty, DYNAMO_NODELIST must be provided
536+
if [[ -z "${dynamo_args["decode-nodelist"]}" && -z "${dynamo_args["prefill-nodelist"]}" ]]; then
537+
if [[ -z "${DYNAMO_NODELIST:-}" ]]; then
538+
log "ERROR: When neither --dynamo-decode-nodelist nor --dynamo-prefill-nodelist is provided, DYNAMO_NODELIST must be set"
539+
exit 1
540+
fi
539541
fi
540542

541543
# Directories

0 commit comments

Comments
 (0)