Merge pull request #772 from srivatsankrishnan/verify-configs

Model Name/ModeL size for verify configs

Author: srivatsankrishnan

src/cloudai/workloads/megatron_bridge/megatron_bridge.py

@@ -17,7 +17,7 @@
 import logging
 from typing import List, Optional, Union, cast
 
-from pydantic import Field, field_validator
+from pydantic import Field, ValidationInfo, field_validator
 
 from cloudai.core import DockerImage, GitRepo, Installable, PythonExecutable
 from cloudai.models.workload import CmdArgs, TestDefinition
@@ -40,8 +40,8 @@ class MegatronBridgeCmdArgs(CmdArgs):
     detach: Optional[bool] = Field(default=None)
 
     # Model/task
-    model_name: str = Field(default="")
-    model_size: str = Field(default="")
+    model_name: str = Field(min_length=1)
+    model_size: str = Field(min_length=1)
     domain: str = Field(default="llm")
     task: str = Field(default="pretrain")
     compute_dtype: str = Field(default="bf16")
@@ -88,6 +88,14 @@ def validate_hf_token(cls, v: Optional[str]) -> Optional[str]:
             raise ValueError("cmd_args.hf_token is required. Please set it to your literal HF token string.")
         return token
 
+    @field_validator("model_name", "model_size", mode="after")
+    @classmethod
+    def validate_model_fields(cls, v: str, info: ValidationInfo) -> str:
+        s = v.strip()
+        if not s:
+            raise ValueError(f"cmd_args.{info.field_name} cannot be empty.")
+        return s
+
 
 class MegatronBridgeTestDefinition(TestDefinition):
     """Megatron-Bridge test definition (CloudAI-managed install + Slurm submission via launcher)."""

tests/slurm_command_gen_strategy/test_megatron_bridge_slurm_command_gen_strategy.py

@@ -85,7 +85,21 @@ def cmd_gen(self, slurm_system: SlurmSystem, test_run: TestRun) -> MegatronBridg
 
     def test_hf_token_empty_is_rejected_by_schema(self) -> None:
         with pytest.raises(Exception, match=r"hf_token"):
-            MegatronBridgeCmdArgs.model_validate({"hf_token": ""})
+            MegatronBridgeCmdArgs.model_validate({"hf_token": "", "model_name": "qwen3", "model_size": "30b_a3b"})
+
+    @pytest.mark.parametrize("field_name", ["model_name", "model_size"])
+    def test_model_fields_empty_string_rejected(self, field_name: str) -> None:
+        data = {"hf_token": "dummy_token", "model_name": "qwen3", "model_size": "30b_a3b"}
+        data[field_name] = ""
+        with pytest.raises(Exception, match=field_name):
+            MegatronBridgeCmdArgs.model_validate(data)
+
+    @pytest.mark.parametrize("field_name", ["model_name", "model_size"])
+    def test_model_fields_whitespace_only_rejected(self, field_name: str) -> None:
+        data = {"hf_token": "dummy_token", "model_name": "qwen3", "model_size": "30b_a3b"}
+        data[field_name] = "   \t  "
+        with pytest.raises(Exception, match=rf"cmd_args\.{field_name} cannot be empty\."):
+            MegatronBridgeCmdArgs.model_validate(data)
 
     def test_git_repos_can_pin_megatron_bridge_commit(self) -> None:
         args = MegatronBridgeCmdArgs(hf_token="dummy_token", model_name="qwen3", model_size="30b_a3b")