-
Notifications
You must be signed in to change notification settings - Fork 42
Megatron Bridge in CloudAI #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
ecf22e8
initial port m-bridge
srivatsankrishnan 1b42e01
m-bridge using slurmcommand stratergy
srivatsankrishnan 59a9b14
latest m-bridge changes
srivatsankrishnan 1a3dcc6
tracked config
srivatsankrishnan 6e39fc3
fix installation sequence
srivatsankrishnan 7fba08b
update container url
srivatsankrishnan d344e58
fix url
srivatsankrishnan 87f03d8
absolute path
srivatsankrishnan 1986de4
fix the caching bug
srivatsankrishnan dd9ed59
fix the container
srivatsankrishnan d32a50e
sanitize the flag/api to reflect changes
srivatsankrishnan 7199e4f
cuda_graph scope logic update
srivatsankrishnan 5eadb51
more api name change fixes
srivatsankrishnan 022cbc6
update to use local path as is
srivatsankrishnan 9960611
add unit test and clean up overrides
srivatsankrishnan 462c6b7
don't pass defaults yet (issue with M-bridge overrides).
srivatsankrishnan c58ccac
keep optional none to they don't get set (M_bridge has override issues)
srivatsankrishnan db742c1
get job_id and redirect m-bridge to own logs
srivatsankrishnan 52b3dd7
fix job id retrival logic
srivatsankrishnan 08bb064
make report generation logic fix
srivatsankrishnan ae12297
fix report parsing logic + unit test
srivatsankrishnan dc6b76b
Merge branch 'main' into m-bridge
srivatsankrishnan 78b919e
fix unit tests/liting etc
srivatsankrishnan 593556c
simplify log finding logic
srivatsankrishnan 0074a6e
fix silent failures during report generation
srivatsankrishnan 62613cb
simplifying extracting shared log-finding and extraction logic.
srivatsankrishnan 2ab4b4f
f-strings or consistent formatting.
srivatsankrishnan 871f460
fix produces "None" string if installed_path is None
srivatsankrishnan a054f4a
fix Assigning detach after construction doesn't update model_fields_set
srivatsankrishnan 120a3c5
Incomplete test assertions
srivatsankrishnan cfa33b9
greptile fixes
srivatsankrishnan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
conf/experimental/megatron_bridge/test/megatron_bridge_qwen_30b.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "megatron_bridge_qwen_30b" | ||
| description = "Megatron-Bridge run via CloudAI SlurmSystem for Qwen3 30B A3B" | ||
| test_template_name = "MegatronBridge" | ||
|
|
||
| extra_container_mounts = [] | ||
|
|
||
| [cmd_args] | ||
| gpu_type = "gb200" | ||
| container_image = "nvcr.io#nvidia/nemo:25.11.01" | ||
|
|
||
| model_name = "qwen3" | ||
| model_size = "30b_a3b" | ||
| gpus_per_node = 4 | ||
| num_gpus = 8 | ||
| domain = "llm" | ||
| task = "pretrain" | ||
| compute_dtype = "fp8_mx" | ||
|
|
||
| hf_token = "REPLACE_ME_WITH_HF_TOKEN" |
22 changes: 22 additions & 0 deletions
22
conf/experimental/megatron_bridge/test_scenario/megatron_bridge_qwen_30b.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "megatron_bridge_qwen_30b" | ||
|
|
||
| [[Tests]] | ||
| id = "megatron_bridge_qwen_30b" | ||
| test_name = "megatron_bridge_qwen_30b" | ||
| num_nodes = "2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from .megatron_bridge import MegatronBridgeCmdArgs, MegatronBridgeTestDefinition | ||
| from .report_generation_strategy import MegatronBridgeReportGenerationStrategy | ||
| from .slurm_command_gen_strategy import MegatronBridgeSlurmCommandGenStrategy | ||
|
|
||
| __all__ = [ | ||
| "MegatronBridgeCmdArgs", | ||
| "MegatronBridgeReportGenerationStrategy", | ||
| "MegatronBridgeSlurmCommandGenStrategy", | ||
| "MegatronBridgeTestDefinition", | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.