Skip to content

Remove hardcoded --distribution=arbitrary #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amaslenn merged 4 commits into from
Jan 5, 2026
Merged

Remove hardcoded --distribution=arbitrary #766

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31c2299
Remove hardcoded --distribution=arbitrary
juntaowww Jan 5, 2026
c8d33c4
Fix tests
juntaowww Jan 5, 2026
8fcc20a
Fix tests
juntaowww Jan 5, 2026
812cf11
Update copyright year
juntaowww Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cloudai/systems/slurm/slurm_command_gen_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,10 @@ def _append_sbatch_directives(self, batch_script_content: List[str]) -> None:
def _append_nodes_related_directives(self, content: List[str]) -> Optional[Path]:
num_nodes, node_list = self.get_cached_nodes_spec()

if self.system.distribution:
content.append(f"#SBATCH --distribution={self.system.distribution}")

if node_list:
content.append("#SBATCH --distribution=arbitrary")
content.append(f"#SBATCH --nodelist={','.join(node_list)}")

hostfile = (self.test_run.output_path / "hostfile.txt").absolute()
Expand All @@ -417,8 +419,6 @@ def _append_nodes_related_directives(self, content: List[str]) -> Optional[Path]
return hostfile

content.append(f"#SBATCH -N {num_nodes}")
if self.system.distribution:
content.append(f"#SBATCH --distribution={self.system.distribution}")

return None

Expand Down
2 changes: 1 addition & 1 deletion tests/slurm_command_gen_strategy/test_common_slurm_command_gen_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ def test_append_distribution_and_hostfile_with_nodes(slurm_system: SlurmSystem,
content: List[str] = []
strategy._append_nodes_related_directives(content)

assert "#SBATCH --distribution=arbitrary" in content
assert "#SBATCH --distribution=block" in content
assert "#SBATCH --nodelist=node1,node2" in content

hostfile_path = strategy.test_run.output_path / "hostfile.txt"
Expand Down
Loading