Skip to content

Make tests more stable on systems with slurm binaries #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amaslenn merged 2 commits into from
Jan 21, 2026
Merged

Make tests more stable on systems with slurm binaries #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3c4487
Make tests more stable on systems with slurm binaries
amaslenn Jan 21, 2026
8c31522
Fix copyrights
amaslenn Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/test_acceptance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,7 @@ def test_req(request, slurm_system: SlurmSystem, partial_tr: partial[TestRun]) -
def test_sbatch_generation(slurm_system: SlurmSystem, test_req: tuple[TestRun, str]):
slurm_system.output_path.mkdir(parents=True, exist_ok=True)
slurm_system.container_mount_home = True
slurm_system.supports_gpu_directives_cache = True

tr = test_req[0]

Expand Down
3 changes: 2 additions & 1 deletion tests/test_single_sbatch_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -100,6 +100,7 @@ def test_sbatch_system_fields(sleep_tr: TestRun, slurm_system: SlurmSystem) -> N

runner.system.account = "test_account"
runner.system.distribution = "test_distribution"
runner.system.supports_gpu_directives_cache = True
runner.system.gpus_per_node = 2
runner.system.ntasks_per_node = 4
runner.system.extra_sbatch_args = ["--test-arg1", "--test-arg2"]
Expand Down