Skip to content

Conversation

@allkoow
Copy link
Contributor

@allkoow allkoow commented Jan 27, 2026

Summary

Remove the public OSU/OMPI example configs from the repository, since public images don’t include OMPI tests (they are available only in private images).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

Two OSU test configuration files are completely removed from the repository. These TOML configuration files, located in conf/common/test/ and conf/common/test_scenario/ directories, are entirely deleted with no replacement content added.

Changes

Cohort / File(s) Summary
OSU Test Configuration Deletion
conf/common/test/osu_test.toml, conf/common/test_scenario/osu_test.toml
Complete removal of both configuration files including license headers, top-level fields (name, test_template_name, description, job_status_check), and configuration sections ([cmd_args], [Tests]) with all associated keys and test entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A little hop, a swift farewell,
Two config files bid us adieu with a spell,
OSU tests fade into the night,
Cleaner configs shining so bright!

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing OSU benchmark configuration files from the repository.
Description check ✅ Passed The description is directly related to the changeset, explaining why OSU/OMPI configs are being removed and providing relevant context about public vs private images.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 27, 2026

Greptile Overview

Greptile Summary

Removes two public example configuration files for OSU benchmarks since OMPI tests are only available in private container images, not in the public nvcr.io#nvidia/pytorch:25.12-py3 image referenced in the configs.

Key changes:

  • Deleted conf/common/test/osu_test.toml - example test configuration for OSU benchmarks
  • Deleted conf/common/test_scenario/osu_test.toml - example test scenario configuration

The OSUBench workload implementation remains intact in the codebase (src/cloudai/workloads/osu_bench/), along with its documentation (doc/workloads/osu.rst) and test fixtures. Users with access to private images containing OMPI tests can still create their own OSU configurations following the documentation examples.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The PR only removes example configuration files without affecting any code functionality. The OSUBench workload implementation, tests, and documentation remain intact. No files in the codebase reference these specific config files, and users with private images can still create their own OSU configurations using the documentation.
  • No files require special attention

Important Files Changed

Filename Overview
conf/common/test/osu_test.toml Removed example OSU test configuration (not available in public images)
conf/common/test_scenario/osu_test.toml Removed example OSU test scenario configuration (not available in public images)

Sequence Diagram

sequenceDiagram
    participant Developer
    participant Repository
    participant OSUWorkload as OSUBench Workload
    participant Documentation
    participant Users

    Developer->>Repository: Remove conf/common/test/osu_test.toml
    Developer->>Repository: Remove conf/common/test_scenario/osu_test.toml
    
    Note over Repository: Example configs removed<br/>(public images lack OMPI tests)
    
    Repository-->>OSUWorkload: Workload implementation remains
    Repository-->>Documentation: Documentation remains (doc/workloads/osu.rst)
    
    Users->>Documentation: Reference examples for custom configs
    Users->>OSUWorkload: Can still use with private images
    
    Note over Users: Users with private images<br/>create their own configs
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@amaslenn amaslenn merged commit 8a14d54 into main Jan 27, 2026
5 checks passed
@amaslenn amaslenn deleted the ako/rm-osu-configs branch January 27, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants