Skip to content

Fix handling of a local path for docker container #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amaslenn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix handling of a local path for docker container #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cloudai/systems/slurm/slurm_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -155,7 +155,7 @@ def is_installed_one(self, item: Installable) -> InstallStatusResult:

def mark_as_installed_one(self, item: Installable) -> InstallStatusResult:
if isinstance(item, DockerImage):
if self.system.cache_docker_images_locally:
if self.system.cache_docker_images_locally and not isinstance(item.installed_path, Path):
item.installed_path = self.system.install_path / item.cache_filename
return InstallStatusResult(True)
elif isinstance(item, GitRepo):
Expand Down
22 changes: 21 additions & 1 deletion tests/test_slurm_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -348,3 +348,23 @@ def test_mark_as_installed_docker_image_system_is_respected(slurm_system: SlurmS
assert docker.installed_path == slurm_system.install_path / docker.cache_filename
else:
assert docker.installed_path == docker.url


def test_mark_as_installed_local_container(slurm_system: SlurmSystem):
"""
Test for marking a local docker image as installed.

The issue appeared when a DockerImage with existing local path was marked as installed,
and installed_path was overwritten with a default value.
"""
installer = SlurmInstaller(slurm_system)
slurm_system.install_path.mkdir(parents=True, exist_ok=True)
local_image = slurm_system.install_path / "local_image.sqsh"
local_image.touch()

docker_image = DockerImage(url=str(local_image.absolute()))
docker_image.installed_path = local_image # simulate installation

installer.mark_as_installed_one(docker_image)

assert docker_image.installed_path == local_image.absolute()