release: record the two backported #217 files as mapped dests - #220
Merged
Conversation
The forward release fails the drift gate with:
DEST BREAK collision: NEW source projects/cosmos3/cosmos3/utils/mixed_precision.py
-> cosmos_framework/utils/generator/mixed_precision.py (already exists in CF, not previously mapped)
DEST BREAK collision: NEW source .../diffusion/samplers/step_callback_test.py
-> .../diffusion/samplers/step_callback_test.py (already exists in CF, not previously mapped)
Both files were authored here in #217 (FP8 mixed-precision diffusion steps) and
backported into imaginaire4 as bfd655d67b. imaginaire4 now maps them, so the
release wants to take ownership of destinations this manifest never declared --
which the gate refuses on purpose, since that is also what an accidental
overwrite of community work looks like.
Declaring them here is the acknowledgement: find_dest_collisions only fires for
a source absent from this manifest, so recording the pair states that our copy
of each destination now comes from that imaginaire4 source. Verified against
imaginaire4 main 173b1aeb83: the release goes from exit 1 with 2 collisions to
exit 0 with none, with no other change.
The adoption is content-safe for mixed_precision.py -- its released form is
AST-identical to ours, differing only in line wrapping from imaginaire4's
formatter. step_callback_test.py additionally gains `import pytest` and
`pytestmark = [pytest.mark.L0, pytest.mark.CPU]`, which imaginaire4's conftest
requires and ours ignores; no markers are declared here and --strict-markers is
off, so they are inert.
Provenance fields are deliberately untouched: no release has shipped yet.
lfengad
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forward release fails the drift gate with two collisions:
Both files were authored here in #217 (FP8 mixed-precision diffusion steps) and
backported into imaginaire4 as
bfd655d67b. imaginaire4 now maps them, so therelease wants to take ownership of destinations this manifest never declared --
which the gate refuses on purpose, since that is also what an accidental
overwrite of community work looks like.
Declaring the pairs here is the acknowledgement:
find_dest_collisionsonlyfires for a source absent from this manifest, so recording each pair states that
our copy of that destination now comes from the imaginaire4 source.
Verified against imaginaire4 main
173b1aeb83: the release goes from exit 1with 2 collisions to exit 0 with zero breaks, with no other change.
Content impact of the adoption
mixed_precision.py-- the released form is AST-identical to ours; theonly differences are line wrapping from imaginaire4's 120-col formatter.
step_callback_test.py-- additionally gainsimport pytestandpytestmark = [pytest.mark.L0, pytest.mark.CPU], which imaginaire4's conftestrequires (it skips unmarked tests) and we do not use. Inert here: no markers
are declared in
pyproject.tomland--strict-markersis off. If you wouldrather not carry them, the alternative is a
COSMOS-RELEASE-IGNORELINEonthose lines in imaginaire4 instead of this adoption.
Provenance fields (
_source_commit,_dest_commit,_generated_at) aredeliberately untouched -- no release has shipped yet.