[features/run] Add return to output logging pass.#2582
Merged
schweitzpgi merged 6 commits intoNVIDIA:features/runfrom Feb 6, 2025
Merged
[features/run] Add return to output logging pass.#2582schweitzpgi merged 6 commits intoNVIDIA:features/runfrom
schweitzpgi merged 6 commits intoNVIDIA:features/runfrom
Conversation
Add test. Add struct test. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
schweitzpgi
force-pushed
the
ch-fr-return.to.output
branch
from
ebd48b3 to
cdf366b
Compare
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
explicitly since it appears GCC-12 isn't smart enough to know how to compile them. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Collaborator
Author
|
The codecov "error" is bogus. We haven't integrated everything. |
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
annagrin
pushed a commit
to annagrin/cuda-quantum
that referenced
this pull request
Jun 17, 2025
* Start to add return to output logging pass. Add test. Add struct test. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> * Workaround overly excitable warnings in GCC 12. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> * Make the labels like the design doc. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> * Update the CHECK lines. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> * Wrap all string building terms in std::string constructors explicitly since it appears GCC-12 isn't smart enough to know how to compile them. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> --------- Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test.
Add struct test.
Description