Skip to content

Run canonical patterns alongside lift-array-alloc#2601

Closed
annagrin wants to merge 2 commits intoNVIDIA:mainfrom
annagrin:lift-array-alloc-array-copy
Closed

Run canonical patterns alongside lift-array-alloc#2601
annagrin wants to merge 2 commits intoNVIDIA:mainfrom
annagrin:lift-array-alloc-array-copy

Conversation

@annagrin
Copy link
Collaborator

@annagrin annagrin commented Feb 9, 2025

Description

Run canonical patterns alongside lift-array-alloc to make sure all constant arrays are lifted in case of array copy:

arr = [0]
arr1 = [arr[0]]
return arr[0] == arr1[0]

Previously, we would need to run two iterations of lift-array-alloc,canonicalize to lift both arrays, as the first one needs to be lifted and then const-propped before the second one could be lifted as well.

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@github-actions
Copy link

github-actions bot commented Feb 9, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 9, 2025
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 10, 2025
@annagrin
Copy link
Collaborator Author

Replaced by #2605

@annagrin annagrin closed this Feb 11, 2025
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant