New launch kernel for python by annagrin · Pull Request #2706 · NVIDIA/cuda-quantum

annagrin · 2025-03-06T23:28:06Z

Description

Use new launch kernel from Python code for quantum devices.

This enables new synthesis (including state synthesis) for quantum devices in Python.

~~Required: #2644~~
~~Requires: #2291~~

Closes: #2299
Towards: #1931

I, Ben Howe <bhowe@nvidia.com>, hereby add my Signed-off-by to this commit: 86681ef Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…antum-device-state

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…antum-device-state

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…antum-device-state

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…antum-device-state

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…antum-device-state Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…ate-ops Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…ate-ops Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

python/runtime/cudaq/platform/py_alt_launch_kernel.cpp

schweitzpgi

LGTM. Thanks, Anna.

python/runtime/cudaq/platform/py_alt_launch_kernel.cpp

python/runtime/utils/PyRemoteRESTQPU.cpp

python/runtime/cudaq/algorithms/py_state.cpp

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…ate-synthesis-python Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…cuda-quantum into state-synthesis-python Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

python/runtime/cudaq/platform/py_alt_launch_kernel.cpp

github-actions · 2025-04-02T19:51:48Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

…ate-synthesis-python Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

github-actions · 2025-04-03T07:04:00Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

…ate-synthesis-python Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: 2dd1ec6 Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

github-actions · 2025-04-03T18:40:42Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

* DCO Remediation Commit for Ben Howe <bhowe@nvidia.com> I, Ben Howe <bhowe@nvidia.com>, hereby add my Signed-off-by to this commit: 86681ef Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * State pointer synthesis for quantum hardware Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Merge with main Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Merge with main Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix test failure on anyon platform Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make StateInitialization a funcOp pass Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix issues and tests for the rest of quantum architectures Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing quantinuum state prep tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Replaced getState intrinsic by cc.get_state op Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove print Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove getCudaqState references Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Minor updates Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing quake test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add a few state-related cc ops Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix test_argument_conversion Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add printing in failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add printing in failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add description for new algorithm for state syntesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make intermediate IR legal by separating allocs * DCO Remediation Commit for Anna Gringauze <agringauze@nvidia.com> I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: 9563371 Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address some PR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Store new functions in subst module and update synthesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make argument synthesis transitive Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Update callers of synthesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Use PointerOf in quake defs Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Addressed more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Recursive with caching Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * StateAggregatorWithArgumentConverter Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make ArgumentConverter handle the state call tree Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make argument converter handle kernels created from states Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Temp Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Temp Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Temp Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Temp Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix null alloc size and add tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix const prop complex and numQubits bugs Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix state copy in python Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove temp files Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Keep storing ops when generating numSubits func Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing doc build Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Allow old launch kernel for tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments and add a test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more python tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links and tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix test on ionq Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Undo unrelated changes Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Undo unrelated changes Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Undo unrelated changes Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Undo unrelated changes Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove unneded unique pointer Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing Ionq test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing Ionq and OQC tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing Ionq and OQC tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove trotter tests for quantum devices Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remote unrelated changes Signed-off-by: Anna Gringauze <agringauze@nvidia.com> --------- Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

bmhowe23 and others added 30 commits October 17, 2024 14:33

DCO Remediation Commit for Ben Howe <bhowe@nvidia.com>

ac01dd1

I, Ben Howe <bhowe@nvidia.com>, hereby add my Signed-off-by to this commit: 86681ef Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

State pointer synthesis for quantum hardware

21a87c1

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge with main

3fc56de

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge with main

7969a75

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Fix test failure on anyon platform

755d0d1

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…

dc5e77e

…antum-device-state

Make StateInitialization a funcOp pass

382bc99

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Fix issues and tests for the rest of quantum architectures

d3a05d4

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge with main

ac151f2

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Fix failing quantinuum state prep tests

51ef054

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…

0cdf3e9

…antum-device-state

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…

5307aa4

…antum-device-state

Address CR comments

a7f5387

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge with main

eb8db13

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Format

9f0937f

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Fix failing test

2f3a623

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Format

b381350

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Format

dc87ca4

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…

e4c7735

…antum-device-state

Replaced getState intrinsic by cc.get_state op

53a34c9

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…

30777f3

…antum-device-state

Remove print

fe6d409

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Remove getCudaqState references

48704e3

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Minor updates

137f621

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Fix failing quake test

ad7c6bc

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into qu…

83683f7

…antum-device-state Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Add a few state-related cc ops

78c0a44

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…

6682c39

…ate-ops Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Fix test_argument_conversion

102f819

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…

6b2c015

…ate-ops Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

schweitzpgi reviewed Apr 1, 2025

View reviewed changes

python/runtime/cudaq/platform/py_alt_launch_kernel.cpp Outdated Show resolved Hide resolved

schweitzpgi approved these changes Apr 1, 2025

View reviewed changes

boschmitt reviewed Apr 2, 2025

View reviewed changes

python/runtime/cudaq/algorithms/py_state.cpp Show resolved Hide resolved

annagrin added 3 commits April 2, 2025 11:17

Address CR comments

5a506e8

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…

f99e3c4

…ate-synthesis-python Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'state-synthesis-python' of https://github.com/annagrin/…

e3f45f5

…cuda-quantum into state-synthesis-python Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

amccaskey reviewed Apr 2, 2025

View reviewed changes

python/runtime/cudaq/platform/py_alt_launch_kernel.cpp Outdated Show resolved Hide resolved

github-actions bot pushed a commit that referenced this pull request Apr 2, 2025

Docs preview for PR #2706.

481946b

annagrin added 4 commits April 2, 2025 14:21

Address CR comments

e2784a2

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Address CR comments

1171b34

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…

30469ff

…ate-synthesis-python Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Remote unrelated changes

5a47157

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

annagrin mentioned this pull request Apr 3, 2025

Revisit state hierarchy (including python states) #2781

Open

annagrin enabled auto-merge (squash) April 3, 2025 00:59

annagrin disabled auto-merge April 3, 2025 01:02

github-actions bot pushed a commit that referenced this pull request Apr 3, 2025

Docs preview for PR #2706.

802220a

annagrin enabled auto-merge (squash) April 3, 2025 16:31

annagrin added 4 commits April 3, 2025 09:47

fix failing tests

2dd1ec6

Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into st…

1cf54d6

…ate-synthesis-python Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

DCO Remediation Commit for Anna Gringauze <agringauze@nvidia.com>

4bc229e

I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: 2dd1ec6 Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

Remove debugging code

8ace3be

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

annagrin merged commit a0f6ac4 into NVIDIA:main Apr 3, 2025
195 checks passed

github-actions bot pushed a commit that referenced this pull request Apr 3, 2025

Cleaning up docs preview for PR #2706.

d5de3db

bettinaheim added the release notes Changes need to be captured in the release notes label May 5, 2025

bettinaheim added this to the release 0.11.0 milestone May 5, 2025

bettinaheim mentioned this pull request May 12, 2025

State synthesis for quantum devices #2291

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New launch kernel for python#2706

New launch kernel for python#2706
annagrin merged 141 commits intoNVIDIA:mainfrom
annagrin:state-synthesis-python

annagrin commented Mar 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

schweitzpgi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

annagrin commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

schweitzpgi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

annagrin commented Mar 6, 2025 •

edited

Loading