Skip to content

Conversation

mitchdz
Copy link
Collaborator

@mitchdz mitchdz commented Sep 10, 2025

note that llvm-lit is not explicitly added as well since it by default uses all available cpus[0].

[0] - https://llvm.org/docs/CommandGuide/lit.html#cmdoption-lit-j

Signed-off-by: Mitchell <[email protected]>
exit 1
fi
ctest --output-on-failure --test-dir build -E "ctest-nvqpp|ctest-targettests"
ctest -j$(nproc) --output-on-failure --test-dir build -E "ctest-nvqpp|ctest-targettests"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing idea! 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some inspiration 🙂

Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this speeds things up without causing thrashing or OOM errors.

@mitchdz
Copy link
Collaborator Author

mitchdz commented Sep 10, 2025

Hope this speeds things up without causing thrashing or OOM errors.

That's my concern. I wonder if this was never done for reasons of tests not setting down properly, but we should see soon.

@bmhowe23
Copy link
Collaborator

Hope this speeds things up without causing thrashing or OOM errors.

That's my concern. I wonder if this was never done for reasons of tests not setting down properly, but we should see soon.

I know that it causes issues on my machine (despite having 128GB memory), but that will be machine specific. It is also not very reliable to do this on a machine with a GPU because at least some of our tests expect to have access to the GPU's full memory, so the random run-to-run variation of timing will cause problems in that situation. (Still worth testing in the CI, though.)

@mitchdz
Copy link
Collaborator Author

mitchdz commented Sep 10, 2025

These tests are CPU only tests, so we should be good with GPU interference. Memory is a valid concern though, especially on shared runners.

@mitchdz
Copy link
Collaborator Author

mitchdz commented Sep 10, 2025

Looks like it doesn't really improve the time that much 🙁

github-actions bot pushed a commit that referenced this pull request Sep 10, 2025
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants